[PATCH 0/1] MR1773: localui: Add additional safety check (Coverity)

[Fabian Maurer (＠DarkShadow44)]

Should not change the logic, but makes Coverity happy
and seems safer

Signed-off-by: Fabian Maurer

[PATCH 1/1] localui: Add additional safety check (Coverity)

[Fabian Maurer]

From: Fabian Maurer

Should not change the logic, but makes Coverity happy
and seems safer

Signed-off-by: Fabian Maurer 
---
 dlls/localui/localui.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/localui/localui.c b/dlls/localui/localui.c
index 643b01d7b3f..5823fc88fa4 100644
--- a/dlls/localui/localui.c
+++ b/dlls/localui/localui.c
@@ -85,8 +85,10 @@ static BOOL dlg_configure_com(HANDLE hXcv, HWND hWnd, PCWSTR pPortName)
     DWORD len;
     BOOL  res;

-    /* strip the colon (pPortName is never empty here) */
+    /* strip the colon (pPortName should never empty be here) */
     len = lstrlenW(pPortName);
+    if (!len)
+        return FALSE;
     shortname = HeapAlloc(GetProcessHeap(), 0, len  * sizeof(WCHAR));
     if (shortname) {
         memcpy(shortname, pPortName, (len -1) * sizeof(WCHAR));

[Alex Henrie (＠alexhenrie)]

I think it would be better to just mark this as a false positive in Coverity.

[Fabian Maurer (＠DarkShadow44)]

Since I found it hard to follow the code to guarantee this assumption, I figured it wouldn't hurt to add an additional safety check.
If you consider it fine as is, please feel free to reject this MR.

PS: I'm a bit hesitant to mark stuff as false-positive in coverity, just in case I'm wrong...

[Fabian Maurer (＠DarkShadow44)]

So, should that be closed? Or does it have merit?

[Alex Henrie (＠alexhenrie)]

On Mon Dec 19 01:15:46 2022 +0000, Fabian Maurer wrote:
> So, should that be closed? Or does it have merit?

My vote is to close the merge request and mark the defect as a false positive in Coverity.

[Fabian Maurer (＠DarkShadow44)]

On Mon Dec 19 01:15:46 2022 +0000, Alex Henrie wrote:
> My vote is to close the merge request and mark the defect as a false
> positive in Coverity.

Okay!

[PATCH 0/1] MR1773: localui: Add additional safety check (Coverity) - closed

[Fabian Maurer (＠DarkShadow44)]

This merge request was closed by Fabian Maurer.