[PATCH 0/1] MR4291: winemac.drv: Fix minimizing windows programmatically from Win32 when Stage Manager is enabled.

[Brendan Shanks (＠bshanks)]

!4192 fixed minimizing for windows that used Mac window decorations, but apps that minimize programmatically (e.g. client-side decorated windows) were still broken. This fixes that case as well.

[PATCH 1/1] winemac.drv: Fix minimizing windows programmatically from Win32 when Stage Manager is enabled.

[Brendan Shanks]

From: Brendan Shanks

---
 dlls/winemac.drv/cocoa_window.m | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m
index 820bb606769..1655ea98ef7 100644
--- a/dlls/winemac.drv/cocoa_window.m
+++ b/dlls/winemac.drv/cocoa_window.m
@@ -1340,10 +1340,20 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi
             {
                 if ([self wouldBeVisible])
                 {
-                    if ([self styleMask] & NSWindowStyleMaskFullScreen)
+                    if (([self styleMask] & NSWindowStyleMaskFullScreen) || stage_manager_enabled())
                     {
                         [self postDidUnminimizeEvent];
                         discard &= ~event_mask_for_type(WINDOW_DID_UNMINIMIZE);
+
+                        /* When Stage Manager is enabled, it's not possible to minimize the window
+                         * (miniaturize: just moves the window to the background).
+                         * Post an unminimize event, then miniaturize:.
+                         */
+                        if (stage_manager_enabled())
+                        {
+                            [self setStyleMask:([self styleMask] | NSWindowStyleMaskMiniaturizable)];
+                            [super miniaturize:nil];
+                        }
                     }
                     else
                     {

[PATCH 1/1] winemac.drv: Fix minimizing windows programmatically from Win32 when Stage Manager is enabled.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=139549

Your paranoid android.

=== debian11b (64 bit WoW report) ===

msi:
action.c:4703: Test failed: File should not exist