Tests show test kernelbase:memory is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#kernelbase:memory
This patch adds skipping the test if function `EnumSystemFirmwareTables` is not found.
From: Bernhard Übelacker bernhardu@mailbox.org
--- dlls/kernelbase/tests/memory.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/dlls/kernelbase/tests/memory.c b/dlls/kernelbase/tests/memory.c index b7841d57fee..b38cea2c258 100644 --- a/dlls/kernelbase/tests/memory.c +++ b/dlls/kernelbase/tests/memory.c @@ -34,6 +34,12 @@ static void test_enum_system_firmware_tables(void) UINT res; DWORD err;
+ if (!pEnumSystemFirmwareTables) + { + skip("Function EnumSystemFirmwareTables not available, skipping.\n"); + return; + } + /* Applications may use e.g. 'ACPI', which we currently don't support. * We should at the very least return valid error codes for it. * Test with a definitely-invalid provider so it also fails on real Windows. */
Jinoh Kang (@iamahuman) commented about dlls/kernelbase/tests/memory.c:
UINT res; DWORD err;
- if (!pEnumSystemFirmwareTables)
- {
skip("Function EnumSystemFirmwareTables not available, skipping.\n");
```suggestion:-0+0 win_skip("Function EnumSystemFirmwareTables not available, skipping.\n"); ```
Looks good otherwise.