From: Zebediah Figura zfigura@codeweavers.com
--- dlls/ddraw/surface.c | 216 +++++++++++++++++++++---------------------- 1 file changed, 108 insertions(+), 108 deletions(-)
diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index a096c5d7d8e..18f4ad0d455 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -1373,114 +1373,114 @@ static void ddraw_texture_rename_to(struct ddraw_texture *dst_texture, struct wi static HRESULT WINAPI DECLSPEC_HOTPATCH ddraw_surface1_Flip(IDirectDrawSurface *iface, IDirectDrawSurface *src, DWORD flags) { - struct ddraw_surface *dst_impl = impl_from_IDirectDrawSurface(iface); - struct ddraw_surface *src_impl = unsafe_impl_from_IDirectDrawSurface(src); - struct ddraw_texture *dst_ddraw_texture, *src_ddraw_texture; - struct wined3d_rendertarget_view *tmp_rtv, *current_rtv; - struct wined3d_texture *texture, *draw_texture; - DDSCAPS caps = {DDSCAPS_FLIP}; - IDirectDrawSurface *current; - void *texture_memory; - HRESULT hr; - - TRACE("iface %p, src %p, flags %#lx.\n", iface, src, flags); - - if (src == iface || !(dst_impl->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_OVERLAY))) - return DDERR_NOTFLIPPABLE; - - if (ddraw_surface_is_lost(dst_impl)) - return DDERR_SURFACELOST; - - wined3d_mutex_lock(); - - if ((dst_impl->surface_desc.ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) - && !(dst_impl->ddraw->cooperative_level & DDSCL_EXCLUSIVE)) - { - WARN("Not in exclusive mode.\n"); - wined3d_mutex_unlock(); - return DDERR_NOEXCLUSIVEMODE; - } - - tmp_rtv = ddraw_surface_get_rendertarget_view(dst_impl); - texture = dst_impl->wined3d_texture; - dst_ddraw_texture = wined3d_texture_get_parent(dst_impl->wined3d_texture); - texture_memory = dst_ddraw_texture->texture_memory; - draw_texture = dst_impl->draw_texture; - current_rtv = wined3d_device_context_get_rendertarget_view(dst_impl->ddraw->immediate_context, 0); - - if (src_impl) - { - for (current = iface; current != src;) - { - if (FAILED(hr = ddraw_surface1_GetAttachedSurface(current, &caps, ¤t))) - { - WARN("Surface %p is not on the same flip chain as surface %p.\n", src, iface); - wined3d_mutex_unlock(); - return DDERR_NOTFLIPPABLE; - } - ddraw_surface1_Release(current); - if (current == iface) - { - WARN("Surface %p is not on the same flip chain as surface %p.\n", src, iface); - wined3d_mutex_unlock(); - return DDERR_NOTFLIPPABLE; - } - } - - src_ddraw_texture = wined3d_texture_get_parent(src_impl->wined3d_texture); - - ddraw_texture_rename_to(dst_ddraw_texture, src_impl->wined3d_texture, src_impl->draw_texture, - ddraw_surface_get_rendertarget_view(src_impl), src_ddraw_texture->texture_memory, current_rtv); - - dst_ddraw_texture = src_ddraw_texture; - } - else - { - for (current = iface;;) - { - if (FAILED(hr = ddraw_surface1_GetAttachedSurface(current, &caps, ¤t))) - { - ERR("Can't find a flip target\n"); - wined3d_mutex_unlock(); - return DDERR_NOTFLIPPABLE; /* Unchecked */ - } - ddraw_surface1_Release(current); - if (current == iface) - { - dst_impl = impl_from_IDirectDrawSurface(iface); - break; - } - - src_impl = impl_from_IDirectDrawSurface(current); - src_ddraw_texture = wined3d_texture_get_parent(src_impl->wined3d_texture); - - ddraw_texture_rename_to(dst_ddraw_texture, src_impl->wined3d_texture, src_impl->draw_texture, - ddraw_surface_get_rendertarget_view(src_impl), src_ddraw_texture->texture_memory, current_rtv); - - dst_ddraw_texture = src_ddraw_texture; - dst_impl = src_impl; - } - } - - ddraw_texture_rename_to(dst_ddraw_texture, texture, draw_texture, tmp_rtv, texture_memory, current_rtv); - - if (flags & ~(DDFLIP_NOVSYNC | DDFLIP_INTERVAL2 | DDFLIP_INTERVAL3 | DDFLIP_INTERVAL4)) - { - static UINT once; - if (!once++) - FIXME("Ignoring flags %#lx.\n", flags); - else - WARN("Ignoring flags %#lx.\n", flags); - } - - if (dst_impl->surface_desc.ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) - hr = ddraw_surface_update_frontbuffer(dst_impl, NULL, FALSE, ddraw_swap_interval_from_flags(flags)); - else - hr = DD_OK; - - wined3d_mutex_unlock(); - - return hr; + ;ɹɥ uɹnʇǝɹ + + ;()ʞɔolun‾xǝʇnɯ‾pƐpǝuᴉʍ + + ;ꞰO‾ꓷꓷ = ɹɥ + ǝslǝ + ;((sᵷɐlɟ)sᵷɐlɟ‾ɯoɹɟ‾lɐʌɹǝʇuᴉ‾dɐʍs‾ʍɐɹpp 'ƎSꓶⱯꓞ 'ꓶꓶՈN 'ldɯᴉ‾ʇsp)ɹǝɟɟnqʇuoɹɟ‾ǝʇɐpdn‾ǝɔɐɟɹns‾ʍɐɹpp = ɹɥ + (ƎƆⱯꓞꓤՈS⅄ꓤⱯWIꓤꓒ‾SꓒⱯƆSꓷꓷ & sdɐƆʍp˙sdɐƆspp˙ɔsǝp‾ǝɔɐɟɹns<-ldɯᴉ‾ʇsp) ɟᴉ + + { + ;(sᵷɐlɟ '"u\˙xl#% sᵷɐlɟ ᵷuᴉɹouᵷI")NꓤⱯM + ǝslǝ + ;(sᵷɐlɟ '"u\˙xl#% sᵷɐlɟ ᵷuᴉɹouᵷI")ƎWXIꓞ + (++ǝɔuo¡) ɟᴉ + ;ǝɔuo ꓕNIՈ ɔᴉʇɐʇs + } + ((4ꓶⱯɅꓤƎꓕNI‾ꓒIꓶꓞꓷꓷ | ƐꓶⱯɅꓤƎꓕNI‾ꓒIꓶꓞꓷꓷ | 2ꓶⱯɅꓤƎꓕNI‾ꓒIꓶꓞꓷꓷ | ƆN⅄SɅON‾ꓒIꓶꓞꓷꓷ)~ & sᵷɐlɟ) ɟᴉ + + ;(ʌʇɹ‾ʇuǝɹɹnɔ 'ʎɹoɯǝɯ‾ǝɹnʇxǝʇ 'ʌʇɹ‾dɯʇ 'ǝɹnʇxǝʇ‾ʍɐɹp 'ǝɹnʇxǝʇ 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp)oʇ‾ǝɯɐuǝɹ‾ǝɹnʇxǝʇ‾ʍɐɹpp + + { + { + ;ldɯᴉ‾ɔɹs = ldɯᴉ‾ʇsp + ;ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs = ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp + + ;(ʌʇɹ‾ʇuǝɹɹnɔ 'ʎɹoɯǝɯ‾ǝɹnʇxǝʇ<-ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs '(ldɯᴉ‾ɔɹs)ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾ʇǝᵷ‾ǝɔɐɟɹns‾ʍɐɹpp + 'ǝɹnʇxǝʇ‾ʍɐɹp<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp)oʇ‾ǝɯɐuǝɹ‾ǝɹnʇxǝʇ‾ʍɐɹpp + + ;(ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs)ʇuǝɹɐd‾ʇǝᵷ‾ǝɹnʇxǝʇ‾pƐpǝuᴉʍ = ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs + ;(ʇuǝɹɹnɔ)ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI‾ɯoɹɟ‾ldɯᴉ = ldɯᴉ‾ɔɹs + + { + ;ʞɐǝɹq + ;(ǝɔɐɟᴉ)ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI‾ɯoɹɟ‾ldɯᴉ = ldɯᴉ‾ʇsp + } + (ǝɔɐɟᴉ == ʇuǝɹɹnɔ) ɟᴉ + ;(ʇuǝɹɹnɔ)ǝsɐǝlǝꓤ‾1ǝɔɐɟɹns‾ʍɐɹpp + { + /* pǝʞɔǝɥɔuՈ */ ;ƎꓶꓭⱯꓒꓒIꓶꓞꓕON‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + ;()ʞɔolun‾xǝʇnɯ‾pƐpǝuᴉʍ + ;("u\ʇǝᵷɹɐʇ dᴉlɟ ɐ puᴉɟ ʇ,uɐƆ")ꓤꓤƎ + } + (((ʇuǝɹɹnɔ& 'sdɐɔ& 'ʇuǝɹɹnɔ)ǝɔɐɟɹnSpǝɥɔɐʇʇⱯʇǝ⅁‾1ǝɔɐɟɹns‾ʍɐɹpp = ɹɥ)ꓷƎꓶIⱯꓞ) ɟᴉ + } + (;;ǝɔɐɟᴉ = ʇuǝɹɹnɔ) ɹoɟ + } + ǝslǝ + { + ;ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs = ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp + + ;(ʌʇɹ‾ʇuǝɹɹnɔ 'ʎɹoɯǝɯ‾ǝɹnʇxǝʇ<-ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs '(ldɯᴉ‾ɔɹs)ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾ʇǝᵷ‾ǝɔɐɟɹns‾ʍɐɹpp + 'ǝɹnʇxǝʇ‾ʍɐɹp<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp)oʇ‾ǝɯɐuǝɹ‾ǝɹnʇxǝʇ‾ʍɐɹpp + + ;(ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs)ʇuǝɹɐd‾ʇǝᵷ‾ǝɹnʇxǝʇ‾pƐpǝuᴉʍ = ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs + + { + { + ;ƎꓶꓭⱯꓒꓒIꓶꓞꓕON‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + ;()ʞɔolun‾xǝʇnɯ‾pƐpǝuᴉʍ + ;(ǝɔɐɟᴉ 'ɔɹs '"u\˙d% ǝɔɐɟɹns sɐ uᴉɐɥɔ dᴉlɟ ǝɯɐs ǝɥʇ uo ʇou sᴉ d% ǝɔɐɟɹnS")NꓤⱯM + } + (ǝɔɐɟᴉ == ʇuǝɹɹnɔ) ɟᴉ + ;(ʇuǝɹɹnɔ)ǝsɐǝlǝꓤ‾1ǝɔɐɟɹns‾ʍɐɹpp + { + ;ƎꓶꓭⱯꓒꓒIꓶꓞꓕON‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + ;()ʞɔolun‾xǝʇnɯ‾pƐpǝuᴉʍ + ;(ǝɔɐɟᴉ 'ɔɹs '"u\˙d% ǝɔɐɟɹns sɐ uᴉɐɥɔ dᴉlɟ ǝɯɐs ǝɥʇ uo ʇou sᴉ d% ǝɔɐɟɹnS")NꓤⱯM + } + (((ʇuǝɹɹnɔ& 'sdɐɔ& 'ʇuǝɹɹnɔ)ǝɔɐɟɹnSpǝɥɔɐʇʇⱯʇǝ⅁‾1ǝɔɐɟɹns‾ʍɐɹpp = ɹɥ)ꓷƎꓶIⱯꓞ) ɟᴉ + } + (;ɔɹs =¡ ʇuǝɹɹnɔ ;ǝɔɐɟᴉ = ʇuǝɹɹnɔ) ɹoɟ + } + (ldɯᴉ‾ɔɹs) ɟᴉ + + ;(0 'ʇxǝʇuoɔ‾ǝʇɐᴉpǝɯɯᴉ<-ʍɐɹpp<-ldɯᴉ‾ʇsp)ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾ʇǝᵷ‾ʇxǝʇuoɔ‾ǝɔᴉʌǝp‾pƐpǝuᴉʍ = ʌʇɹ‾ʇuǝɹɹnɔ + ;ǝɹnʇxǝʇ‾ʍɐɹp<-ldɯᴉ‾ʇsp = ǝɹnʇxǝʇ‾ʍɐɹp + ;ʎɹoɯǝɯ‾ǝɹnʇxǝʇ<-ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp = ʎɹoɯǝɯ‾ǝɹnʇxǝʇ + ;(ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ʇsp)ʇuǝɹɐd‾ʇǝᵷ‾ǝɹnʇxǝʇ‾pƐpǝuᴉʍ = ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp + ;ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ʇsp = ǝɹnʇxǝʇ + ;(ldɯᴉ‾ʇsp)ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾ʇǝᵷ‾ǝɔɐɟɹns‾ʍɐɹpp = ʌʇɹ‾dɯʇ + + { + ;ƎꓷOWƎɅISՈꓶƆXƎON‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + ;()ʞɔolun‾xǝʇnɯ‾pƐpǝuᴉʍ + ;("u\˙ǝpoɯ ǝʌᴉsnlɔxǝ uᴉ ʇoN")NꓤⱯM + } + ((ƎɅISՈꓶƆXƎ‾ꓶƆSꓷꓷ & lǝʌǝl‾ǝʌᴉʇɐɹǝdooɔ<-ʍɐɹpp<-ldɯᴉ‾ʇsp)¡ && + (ƎƆⱯꓞꓤՈS⅄ꓤⱯWIꓤꓒ‾SꓒⱯƆSꓷꓷ & sdɐƆʍp˙sdɐƆspp˙ɔsǝp‾ǝɔɐɟɹns<-ldɯᴉ‾ʇsp)) ɟᴉ + + ;()ʞɔol‾xǝʇnɯ‾pƐpǝuᴉʍ + + ;ꓕSOꓶƎƆⱯꓞꓤՈS‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + ((ldɯᴉ‾ʇsp)ʇsol‾sᴉ‾ǝɔɐɟɹns‾ʍɐɹpp) ɟᴉ + + ;ƎꓶꓭⱯꓒꓒIꓶꓞꓕON‾ꓤꓤƎꓷꓷ uɹnʇǝɹ + (((⅄ⱯꓶꓤƎɅO‾SꓒⱯƆSꓷꓷ | ꓤƎꓞꓞՈꓭꓕNOꓤꓞ‾SꓒⱯƆSꓷꓷ) & sdɐƆʍp˙sdɐƆspp˙ɔsǝp‾ǝɔɐɟɹns<-ldɯᴉ‾ʇsp)¡ || ǝɔɐɟᴉ == ɔɹs) ɟᴉ + + ;(sᵷɐlɟ 'ɔɹs 'ǝɔɐɟᴉ '"u\˙xl#% sᵷɐlɟ 'd% ɔɹs 'd% ǝɔɐɟᴉ")ƎƆⱯꓤꓕ + + ;ɹɥ ꓕꓶՈSƎꓤH + ;ʎɹoɯǝɯ‾ǝɹnʇxǝʇ* pᴉoʌ + ;ʇuǝɹɹnɔ* ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI + ;{ꓒIꓶꓞ‾SꓒⱯƆSꓷꓷ} = sdɐɔ SꓒⱯƆSꓷꓷ + ;ǝɹnʇxǝʇ‾ʍɐɹp* 'ǝɹnʇxǝʇ* ǝɹnʇxǝʇ‾pƐpǝuᴉʍ ʇɔnɹʇs + ;ʌʇɹ‾ʇuǝɹɹnɔ* 'ʌʇɹ‾dɯʇ* ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾pƐpǝuᴉʍ ʇɔnɹʇs + ;ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs* 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp* ǝɹnʇxǝʇ‾ʍɐɹpp ʇɔnɹʇs + ;(ɔɹs)ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI‾ɯoɹɟ‾ldɯᴉ‾ǝɟɐsun = ldɯᴉ‾ɔɹs* ǝɔɐɟɹns‾ʍɐɹpp ʇɔnɹʇs + ;(ǝɔɐɟᴉ)ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI‾ɯoɹɟ‾ldɯᴉ = ldɯᴉ‾ʇsp* ǝɔɐɟɹns‾ʍɐɹpp ʇɔnɹʇs }
static HRESULT WINAPI DECLSPEC_HOTPATCH ddraw_surface7_Flip(IDirectDrawSurface7 *iface,
Hi,
It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated.
The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=144527
Your paranoid android.
=== debian11 (build log) ===
../wine/dlls/ddraw/surface.c:1376:104: error: unknown type name ���������� ../wine/dlls/ddraw/surface.c:1378:92: error: expected expression before ���)��� token ../wine/dlls/ddraw/surface.c:1378:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1378:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1380:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1380:99: error: unknown type name ������O��� ../wine/dlls/ddraw/surface.c:1380:115: error: ���������� undeclared (first use in this function) ../wine/dlls/ddraw/surface.c:1381:109: error: expected ���,��� or ���;��� before �����sl����� ../wine/dlls/ddraw/surface.c:1382:12: error: ���s�����l����� undeclared (first use in this function) ../wine/dlls/ddraw/surface.c:1382:22: error: expected ���)��� before ���s�����l����� ../wine/dlls/ddraw/surface.c:1382:31: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:41: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:59: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:68: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:105: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1383:80: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1383:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1383:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1386:79: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1388:78: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1389:106: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1392:28: error: invalid suffix "����������������NI" on integer constant ../wine/dlls/ddraw/surface.c:1392:47: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:111: error: invalid suffix "����������������NI" on integer constant ../wine/dlls/ddraw/surface.c:1392:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:163: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:17: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:68: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:115: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1398:93: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1398:111: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:80: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:91: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:125: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:10: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:96: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:140: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:150: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:165: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:99: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1404:45: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:69: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:88: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:98: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:113: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:143: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:107: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:137: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:134: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1412:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1412:104: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1412:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1414:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1415:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1415:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1418:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1418:106: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1418:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:84: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:118: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:14: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:118: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:144: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:169: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:70: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:94: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:103: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1429:49: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:73: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:92: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:102: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:147: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:158: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1433:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1434:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1434:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1438:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1438:104: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1438:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1440:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1441:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1441:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1444:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1444:106: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1444:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1446:80: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1448:108: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1450:19: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1451:88: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1451:107: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1451:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:74: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:135: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:53: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:77: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:120: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:150: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:161: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1454:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1454:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:83: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:109: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:134: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1458:106: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1459:97: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1459:108: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:64: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:132: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:140: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1463:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1463:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1463:153: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1465:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1465:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1467:109: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:86: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:99: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:106: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:121: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1470:113: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:30: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:162: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1473:116: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1476:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1478:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1479:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1479:91: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1480:64: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1480:81: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1481:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1481:77: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1481:87: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1482:83: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:93: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:125: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:147: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:94: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:124: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:145: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:7093:1: error: expected declaration or statement at end of input Task: The win32 Wine build failed
=== debian11b (build log) ===
../wine/dlls/ddraw/surface.c:1376:104: error: unknown type name ���������� ../wine/dlls/ddraw/surface.c:1378:92: error: expected expression before ���)��� token ../wine/dlls/ddraw/surface.c:1378:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1378:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1380:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1380:99: error: unknown type name ������O��� ../wine/dlls/ddraw/surface.c:1380:115: error: ���������� undeclared (first use in this function) ../wine/dlls/ddraw/surface.c:1381:109: error: expected ���,��� or ���;��� before �����sl����� ../wine/dlls/ddraw/surface.c:1382:12: error: ���s�����l����� undeclared (first use in this function) ../wine/dlls/ddraw/surface.c:1382:22: error: expected ���)��� before ���s�����l����� ../wine/dlls/ddraw/surface.c:1382:31: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:41: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:59: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:68: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1382:105: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1383:80: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1383:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1383:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1386:79: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1388:78: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1389:106: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1392:28: error: invalid suffix "����������������NI" on integer constant ../wine/dlls/ddraw/surface.c:1392:47: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:111: error: invalid suffix "����������������NI" on integer constant ../wine/dlls/ddraw/surface.c:1392:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1392:163: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:17: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:68: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1394:115: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1398:93: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1398:111: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:80: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:91: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1399:125: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:10: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:96: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:140: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:150: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1401:165: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1402:99: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1404:45: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:69: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:88: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:98: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:113: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:143: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1404:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:107: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1405:137: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1409:134: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1412:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1412:104: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1412:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1414:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1415:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1415:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1418:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1418:106: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1418:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:84: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:118: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1424:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:14: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:118: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:144: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1426:169: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:70: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:94: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1427:103: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1429:49: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:73: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:92: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:102: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:147: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1429:158: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1433:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1434:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1434:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1438:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1438:104: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1438:117: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1440:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1441:89: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1441:100: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1444:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1444:106: error: invalid suffix "����������ns" on integer constant ../wine/dlls/ddraw/surface.c:1444:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1446:80: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1448:108: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1450:19: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1451:88: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1451:107: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1451:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:74: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1452:135: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:53: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:77: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:105: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:120: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:150: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1453:161: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1454:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1454:114: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:83: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:109: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:119: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:134: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1455:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1458:106: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1459:97: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1459:108: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:64: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:90: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:132: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1462:140: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1463:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1463:129: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1463:153: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1465:101: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1465:112: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1467:109: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:86: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:99: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:106: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1468:121: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1470:113: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:30: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:130: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:154: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1471:162: error: stray ���\302��� in program ../wine/dlls/ddraw/surface.c:1473:116: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1476:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1478:95: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1479:79: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1479:91: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1480:64: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1480:81: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1481:66: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1481:77: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1481:87: error: missing terminating ' character ../wine/dlls/ddraw/surface.c:1482:83: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:93: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:103: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:125: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1482:147: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:94: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:104: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:124: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:1483:145: error: stray ���\342��� in program ../wine/dlls/ddraw/surface.c:7093:1: error: expected declaration or statement at end of input Task: The wow64 Wine build failed
This merge request was approved by Mohamad Al-Jaf.
This is causing test failures in the Australian debianydoo testbot but it could just be a flaky test.
I was going to add a 👍 reaction, but 🖕 seems more appropriate.
Jinoh Kang (@iamahuman) commented about dlls/ddraw/surface.c:
static HRESULT WINAPI DECLSPEC_HOTPATCH ddraw_surface1_Flip(IDirectDrawSurface *iface, IDirectDrawSurface *src, DWORD flags) {
- struct ddraw_surface *dst_impl = impl_from_IDirectDrawSurface(iface);
This flips along XY unconditionally; please respect the flags so we only flip around the correct axis.
Jinoh Kang (@iamahuman) commented about dlls/ddraw/surface.c:
;(ʌʇɹ‾ʇuǝɹɹnɔ 'ʎɹoɯǝɯ‾ǝɹnʇxǝʇ 'ʌʇɹ‾dɯʇ 'ǝɹnʇxǝʇ‾ʍɐɹp 'ǝɹnʇxǝʇ 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp)oʇ‾ǝɯɐuǝɹ‾ǝɹnʇxǝʇ‾ʍɐɹpp{{;ldɯᴉ‾ɔɹs = ldɯᴉ‾ʇsp;ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs = ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp- ;(ʌʇɹ‾ʇuǝɹɹnɔ 'ʎɹoɯǝɯ‾ǝɹnʇxǝʇ<-ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs '(ldɯᴉ‾ɔɹs)ʍǝᴉʌ‾ʇǝᵷɹɐʇɹǝpuǝɹ‾ʇǝᵷ‾ǝɔɐɟɹns‾ʍɐɹpp
'ǝɹnʇxǝʇ‾ʍɐɹp<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs 'ǝɹnʇxǝʇ‾ʍɐɹpp‾ʇsp)oʇ‾ǝɯɐuǝɹ‾ǝɹnʇxǝʇ‾ʍɐɹpp;(ǝɹnʇxǝʇ‾pƐpǝuᴉʍ<-ldɯᴉ‾ɔɹs)ʇuǝɹɐd‾ʇǝᵷ‾ǝɹnʇxǝʇ‾pƐpǝuᴉʍ = ǝɹnʇxǝʇ‾ʍɐɹpp‾ɔɹs;(ʇuǝɹɹnɔ)ǝɔɐɟɹnSʍɐɹꓷʇɔǝɹᴉꓷI‾ɯoɹɟ‾ldɯᴉ = ldɯᴉ‾ɔɹs{;ʞɐǝɹq
Have you considered compacting this scanline? This will cause regression due to quadrapled framebuffer memory usage. There *has* to be a better way.
On Mon Apr 1 20:50:29 2024 +0000, Jinoh Kang wrote:
This flips along XY unconditionally; please respect the flags so we only flip around the correct axis.
No, the rotate is correct. Despite the name Flip() is supposed to rotate the whole swapchain (backbuffer 1 becomes frontbuffer, backbuffer 2 becomes backbuffer 1, etc.)
On Mon Apr 1 20:50:30 2024 +0000, Jinoh Kang wrote:
Have you considered compacting this scanline? This will cause regression due to quadrapled framebuffer memory usage. There *has* to be a better way.
They're zero pixels, so I don't think the GPU does any work when drawing them???
This merge request was closed by Elizabeth Figura.
-
Alex Henrie (＠alexhenrie) -
Elizabeth Figura (＠zfigura)
-
Jinoh Kang (＠iamahuman)
-
Marvin -
Mohamad Al-Jaf (＠maljaf)
-
Zebediah Figura
-
Zebediah Figura (＠zfigura)