[PATCH v2 0/1] MR1449: msado15: Avoid uninitialized variable use in fields_get_Item

[Gerald Pfeifer (＠gerald)]

This avoids the following warning by GCC 13:

dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized

--
  v2: msado15: Avoid uninitialized variable use in fields_get_Item

https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

[PATCH v2 1/1] msado15: Avoid uninitialized variable use in fields_get_Item

[Gerald Pfeifer]

From: Gerald Pfeifer

This avoids the following warning by GCC 13:
dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized
---
 dlls/msado15/recordset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c
index 177938af2f7..aa2db6e2968 100644
--- a/dlls/msado15/recordset.c
+++ b/dlls/msado15/recordset.c
@@ -781,7 +781,7 @@ static HRESULT WINAPI fields_get_Item( Fields *iface, VARIANT index, Field **obj
 {
     struct fields *fields = impl_from_Fields( iface );
     HRESULT hr;
-    ULONG i;
+    ULONG i = 0;

TRACE( "%p, %s, %p\n", fields, debugstr_variant(&index), obj );

[PATCH v2 1/1] msado15: Avoid uninitialized variable use in fields_get_Item

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126504

Your paranoid android.

=== debian11 (32 bit report) ===

d3d9:
stateblock: Timeout
visual: Timeout

d3dcompiler_43:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_46:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_47:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3drm:
d3drm: Timeout
vector: Timeout

d3dx10_34:
d3dx10: Timeout

d3dx10_35:
d3dx10: Timeout

Report validation errors:
d3dx10: Timeout

=== debian11 (build log) ===

WineRunWineTest.pl:error: The task timed out

[Gerald Pfeifer (＠gerald)]

Thank you, Hans! I updated the branch and (hopefully correctly) resubmitted an adjusted patch.

[Hans Leidekker (＠hans)]

Looks good now, though the patch title would be better with s/use/warning/

[PATCH v2 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item

[Gerald Pfeifer (＠gerald)]

On Sun Nov 20 17:08:43 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=126504
> Your paranoid android.
> === debian11 (32 bit report) ===
> d3d9:
> stateblock: Timeout
> visual: Timeout
> d3dcompiler_43:
> asm: Timeout
> blob: Timeout
> hlsl_d3d11: Timeout
> hlsl_d3d9: Timeout
> reflection: Timeout
> d3dcompiler_46:
> asm: Timeout
> blob: Timeout
> hlsl_d3d11: Timeout
> hlsl_d3d9: Timeout
> reflection: Timeout
> d3dcompiler_47:
> asm: Timeout
> blob: Timeout
> hlsl_d3d11: Timeout
> hlsl_d3d9: Timeout
> reflection: Timeout
> d3drm:
> d3drm: Timeout
> vector: Timeout
> d3dx10_34:
> d3dx10: Timeout
> d3dx10_35:
> d3dx10: Timeout
> Report validation errors:
> d3dx10: Timeout
> === debian11 (build log) ===
> WineRunWineTest.pl:error: The task timed out

False positives.

[PATCH v2 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item

[Gerald Pfeifer (＠gerald)]

On Mon Nov 21 07:39:50 2022 +0000, Hans Leidekker wrote:
> Looks good now, though the patch title would be better with s/use/warning/

Done (and thank you)!

[PATCH v2 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item

[Hans Leidekker (＠hans)]

On Mon Nov 21 07:39:50 2022 +0000, Gerald Pfeifer wrote:
> Done (and thank you)!

You changed the MR title but the commit still has the old title.