[PATCH v8 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly..

[Zhao Yi (＠Zhaoyi)]

Same as MR !2394

Signed-off-by: Zhao Yi [e-mail]

--
  v8: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly.

https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

[PATCH v8 1/1] comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly.

[Zhao Yi]

From: Zhao Yi

Signed-off-by: Zhao Yi 
---
 dlls/comctl32/listview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 750e447dbef..7972be9669d 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -5590,6 +5590,7 @@ static BOOL LISTVIEW_DeleteAllItems(LISTVIEW_INFO *infoPtr, BOOL destroy)
         LISTVIEW_UpdateScroll(infoPtr);
     }
     LISTVIEW_InvalidateList(infoPtr);
+    infoPtr->bNoItemMetrics = TRUE;

return TRUE;
 }

[PATCH v8 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly. - approved

[Zhiyi Zhang (＠zhiyi)]

This merge request was approved by Zhiyi Zhang.

[PATCH v8 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly.

[Zhiyi Zhang (＠zhiyi)]

The commit message subject can probably be improved but I am not going to hold this commit any longer because of that.

[PATCH v8 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly.

[Zhao Yi (＠Zhaoyi)]

On Mon Jul 31 02:01:00 2023 +0000, Nikolay Sivov wrote:
> Commit message needs to describe the purpose of the change, not to
> duplicate what's obviously seen from the change itself.

@nsivov

Hi Nikolay,

I have modified the commit message, please review it again.

[PATCH v8 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged correctly. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.