Re: [PATCH v7 0/1] MR3422: ddraw tests for Pick and GetPickRecords

[Stefan Dösinger (＠stefan)]

On Fri Mar  8 17:52:04 2024 +0000, Stefan Dösinger wrote:
> So on my Radeon 9000 (r250), Windows XP, this produces no pick results
> for the HW device:
> ddraw1.c:15913: Driver string: "ati2dvag.dll"
> ddraw1.c:15914: Description string: "Mobility Radeon 9000"
> ddraw1.c:15915: Driver version 0.0.0.0
> ddraw1.c:15638: Test failed: run {84e63de0-46aa-11cf-816f-0000c020156e}
> ddraw1.c:15689: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15696: Test failed: Got incorrect number of pick records
> (expected 3): 0.
> ddraw1.c:15728: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15737: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15765: Test failed: Got an unexpected ratio of pick
> hits/misses: 0/256.
> ddraw1.c:15805: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15817: Test failed: Got incorrect number of pick records
> (expected 3): 0.
> ddraw1.c:15829: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15838: Test failed: Got incorrect number of pick records
> (expected 1): 0.
> ddraw1.c:15866: Test failed: Got an unexpected ratio of pick
> hits/misses: 0/256.
> ddraw1.c:15638: Test failed: run {a4665c60-2673-11cf-a31a-00aa00b93356}
> 08f4:ddraw1: 204 tests executed (0 marked as todo, 0 as flaky, 12
> failures), 0 skipped.
>
> I'll try to figure out why and see if I can test the game that inspired
> the original author to implement this method to see if it works.
> The RGB device works as expected.

The test passes on the HW device of my way newer Radeon Polaris card on Windows 11. As of now I am unsuccessful in getting my Radeon 9000 from 2002 to produce any pick results.

On a quick test run it seems Lego Island is happy with setting *count = 0 in IDirect3DDevice::GetPickRecords. That prevents it from trying to essentially malloc a random amount of memory. But I am not entirely certain, the menu of this game is confusing. I was (intellectually) unable to start a game even on Windows...

I am downloading FIGHTING to see if it works on my old machine and to see if it uses a HW device or just the RGB device. Judging by the screenshots it might just software render.