[PATCH v6 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub

[Etaash Mathamsetty (＠etaash.mathamsetty)]

This should help to get the nox android emulator to run  
fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760

--
  v6: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub

https://gitlab.winehq.org/wine/wine/-/merge_requests/777

[PATCH v6 1/1] ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub

[Etaash Mathamsetty]

From: Etaash Mathamsetty

---
 dlls/ntoskrnl.exe/ntoskrnl.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c
index 031e9900544..69b91961700 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/ntoskrnl.c
@@ -2777,8 +2777,22 @@ PVOID WINAPI MmAllocateContiguousMemorySpecifyCache( SIZE_T size,
                                                      PHYSICAL_ADDRESS BoundaryAddressMultiple,
                                                      MEMORY_CACHING_TYPE CacheType )
 {
-    FIXME(": stub\n");
-    return NULL;
+    DWORD protect = PAGE_READWRITE;
+    FIXME( ": ( %Iu %s %s %s %x ) semi-stub\n", size, wine_dbgstr_longlong(lowest_valid_address.QuadPart),
+                                            wine_dbgstr_longlong(highest_valid_address.QuadPart),
+                                            wine_dbgstr_longlong(BoundaryAddressMultiple.QuadPart), CacheType );
+    switch (CacheType)
+    {
+        case MmNonCached:
+            protect |= PAGE_NOCACHE;
+            break;
+        case MmWriteCombined:
+            protect |= PAGE_WRITECOMBINE;
+            break;
+        default:
+            break;
+    }
+    return VirtualAlloc( NULL, size, MEM_RESERVE|MEM_COMMIT, protect );
 }

/***********************************************************************

[Bernhard Kölbl (＠besentv)]

On Tue Sep  6 01:01:04 2022 +0000, Etaash Mathamsetty wrote:
> The problem is that I didn't modify anything related to that test

What happens when you run those tests locally without the change you made.

[Jinoh Kang (＠iamahuman)]

On Mon Sep 12 07:04:20 2022 +0000, Bernhard K��lbl wrote:
> What happens when you run those tests locally without the change you made.

IIRC it's a known flaky test.

[Bernhard Kölbl (＠besentv)]

On Mon Sep 12 07:21:54 2022 +0000, Jinoh Kang wrote:
> IIRC it's a known flaky test.

I see. Well then the next thing to do would be using the correct commit naming.

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Mon Sep 12 08:24:25 2022 +0000, Bernhard Kölbl wrote:
> I see. Well then the next thing to do would be using the correct commit naming.

is the commit naming correct now?