[PATCH 0/2] MR8075: windows.networking.connectivity: Implement NetworkInformation IActivationFactory::GetRuntimeClassName().

[Mohamad Al-Jaf (＠maljaf)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58239

[PATCH 1/2] windows.networking.connectivity/tests: Add NetworkInformation IActivationFactory::GetRuntimeClassName() test.

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf

---
 dlls/windows.networking.connectivity/tests/connectivity.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/dlls/windows.networking.connectivity/tests/connectivity.c b/dlls/windows.networking.connectivity/tests/connectivity.c
index 88634cbea95..80af03b4b67 100644
--- a/dlls/windows.networking.connectivity/tests/connectivity.c
+++ b/dlls/windows.networking.connectivity/tests/connectivity.c
@@ -80,6 +80,13 @@ static void test_NetworkInformationStatics(void)
     hr = IActivationFactory_QueryInterface( factory, &IID_INetworkInformationStatics, (void **)&network_information_statics );
     ok( hr == S_OK, "got hr %#lx.\n", hr );

+    str = (void *)0xdeadbeef;
+    hr = IActivationFactory_GetRuntimeClassName( factory, &str );
+    todo_wine
+    ok( hr == E_ILLEGAL_METHOD_CALL, "got hr %#lx.\n", hr );
+    todo_wine
+    ok( str == NULL, "got str %s.\n", wine_dbgstr_hstring( str ) );
+
     hr = CoCreateInstance( &CLSID_NetworkListManager, NULL, CLSCTX_INPROC_SERVER, &IID_INetworkListManager, (void **)&network_list_manager );
     ok( hr == S_OK, "got hr %#lx.\n", hr );
     if (FAILED(hr))

[PATCH 2/2] windows.networking.connectivity: Implement NetworkInformation IActivationFactory::GetRuntimeClassName().

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58239
---
 dlls/windows.networking.connectivity/network_information.c | 6 ++++--
 dlls/windows.networking.connectivity/tests/connectivity.c  | 2 --
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/windows.networking.connectivity/network_information.c b/dlls/windows.networking.connectivity/network_information.c
index fa041fce754..59878dfbfa3 100644
--- a/dlls/windows.networking.connectivity/network_information.c
+++ b/dlls/windows.networking.connectivity/network_information.c
@@ -89,8 +89,10 @@ static HRESULT WINAPI factory_GetIids( IActivationFactory *iface, ULONG *iid_cou

static HRESULT WINAPI factory_GetRuntimeClassName( IActivationFactory *iface, HSTRING *class_name )
 {
-    FIXME( "iface %p, class_name %p stub!\n", iface, class_name );
-    return E_NOTIMPL;
+    TRACE( "iface %p, class_name %p\n", iface, class_name );
+
+    if (class_name) *class_name = NULL;
+    return E_ILLEGAL_METHOD_CALL;
 }

static HRESULT WINAPI factory_GetTrustLevel( IActivationFactory *iface, TrustLevel *trust_level )
diff --git a/dlls/windows.networking.connectivity/tests/connectivity.c b/dlls/windows.networking.connectivity/tests/connectivity.c
index 80af03b4b67..dc963d8bb9a 100644
--- a/dlls/windows.networking.connectivity/tests/connectivity.c
+++ b/dlls/windows.networking.connectivity/tests/connectivity.c
@@ -82,9 +82,7 @@ static void test_NetworkInformationStatics(void)

str = (void *)0xdeadbeef;
     hr = IActivationFactory_GetRuntimeClassName( factory, &str );
-    todo_wine
     ok( hr == E_ILLEGAL_METHOD_CALL, "got hr %#lx.\n", hr );
-    todo_wine
     ok( str == NULL, "got str %s.\n", wine_dbgstr_hstring( str ) );

hr = CoCreateInstance( &CLSID_NetworkListManager, NULL, CLSCTX_INPROC_SERVER, &IID_INetworkListManager, (void **)&network_list_manager );

[Rémi Bernon (＠rbernon)]

This seems okay but I would be surprised it makes any difference for the application, can we confirm that it does?

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.networking.connectivity/network_information.c:
> static HRESULT WINAPI factory_GetRuntimeClassName( IActivationFactory *iface, HSTRING *class_name )
>  {
> - FIXME( "iface %p, class_name %p stub!\n", iface, class_name );
> - return E_NOTIMPL;
> - TRACE( "iface %p, class_name %p\n", iface, class_name );
> -
> - if (class_name) *class_name = NULL;

Checking the pointer seem unnecessary.