[PATCH 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.

[Vijay Kiran Kamuju (＠infyquest)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662

Tests are not provided as its interactive.

[PATCH 1/1] cmd: Do not set enviroment variable when no input is provided by set /p command.

[Vijay Kiran Kamuju]

From: Vijay Kiran Kamuju

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662
---
 programs/cmd/builtins.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index 708e3c6dce6..d3182be99ea 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -3161,7 +3161,7 @@ void WCMD_setshow_env (WCHAR *s) {
       if (string[count-2] == '\r') string[count-2] = '\0'; /* Under Windoze we get CRLF! */
       WINE_TRACE("set /p: Setting var '%s' to '%s'\n", wine_dbgstr_w(s),
                  wine_dbgstr_w(string));
-      SetEnvironmentVariableW(s, string);
+      if(wcslen(string)) SetEnvironmentVariableW(s, string);
     }

/* See if /A supplied, and if so calculate the results of all the expressions */

[PATCH 1/1] cmd: Do not set enviroment variable when no input is provided by set /p command.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=146724

Your paranoid android.

=== debian11b (64 bit WoW report) ===

user32:
input.c:5944: Test failed: got pos (49,51)