[PATCH 0/1] MR4170: mf: Shutdown media sinks before releasing them.

[Yuxuan Shui (＠yshui)]

This probably suppresses !3067

[PATCH 1/1] mf: Shutdown media sinks before releasing them.

[Yuxuan Shui]

From: Yuxuan Shui

---
 dlls/mf/session.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c
index b5b631fb00a..b3312fda333 100644
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -845,8 +845,14 @@ static void session_clear_presentation(struct media_session *session)
     {
         list_remove(&sink->entry);

-        if (sink->sink)
+        if (sink->sink) {
+            /* The way we use media sinks, makes them hold references to themselves. For example,
+             * we call `BeginGetEvent` on `IMFMediaEventGenerator`s with the generators themselves
+             * as states. This creates reference cycles which must be broken by calling
+             * `IMFMediaSink_Shutdown`, to prevent references from leaking. */
+            IMFMediaSink_Shutdown(sink->sink);
             IMFMediaSink_Release(sink->sink);
+        }
         if (sink->preroll)
             IMFMediaSinkPreroll_Release(sink->preroll);
         if (sink->event_generator)

[PATCH 1/1] mf: Shutdown media sinks before releasing them.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=139031

Your paranoid android.

=== debian11 (32 bit report) ===

mf:
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.

=== debian11b (64 bit WoW report) ===

mfmediaengine:
mfmediaengine.c:2339: Test succeeded inside todo block: Got unexpected refcount 0.

mf:
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.
mf.c:1705: Test failed: Unexpected call.