[PATCH v4 0/1] MR2713: kernelbase: Add GetPackagesByPackageFamily stub.

[Etaash Mathamsetty (＠etaash.mathamsetty)]

webview2 uses this function to locate media foundation. 
I also saw the UWP version of FH5 calling this function as well, interestingly.

--
  v4: kernelbase: Add GetPackagesByPackageFamily stub.

https://gitlab.winehq.org/wine/wine/-/merge_requests/2713

[PATCH v4 1/1] kernelbase: Add GetPackagesByPackageFamily stub.

[Etaash Mathamsetty]

From: Etaash Mathamsetty

---
 dlls/kernel32/kernel32.spec     |  1 +
 dlls/kernelbase/kernelbase.spec |  2 +-
 dlls/kernelbase/version.c       | 15 +++++++++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index 16ce6ffa41e..f2fb2979e61 100644
--- a/dlls/kernel32/kernel32.spec
+++ b/dlls/kernel32/kernel32.spec
@@ -774,6 +774,7 @@
 @ stdcall -import GetUserPreferredUILanguages(long ptr ptr ptr)
 @ stdcall GetPackageFamilyName(long ptr ptr) kernelbase.GetPackageFamilyName
 @ stdcall GetPackageFullName(long ptr ptr) kernelbase.GetPackageFullName
+@ stdcall -import GetPackagesByPackageFamily(wstr ptr ptr ptr ptr)
 @ stdcall -import GetPhysicallyInstalledSystemMemory(ptr)
 @ stdcall -import GetPriorityClass(long)
 @ stdcall GetPrivateProfileIntA(str str long str)
diff --git a/dlls/kernelbase/kernelbase.spec b/dlls/kernelbase/kernelbase.spec
index af3af8ecabe..9fd9ad5f038 100644
--- a/dlls/kernelbase/kernelbase.spec
+++ b/dlls/kernelbase/kernelbase.spec
@@ -643,7 +643,7 @@
 # @ stub GetPackageStatusForUser
 # @ stub GetPackageTargetPlatformProperty
 # @ stub GetPackageVolumeSisPath
-# @ stub GetPackagesByPackageFamily
+@ stdcall GetPackagesByPackageFamily(wstr ptr ptr ptr ptr)
 @ stdcall GetPerformanceInfo(ptr long)
 @ stdcall GetPhysicallyInstalledSystemMemory(ptr)
 # @ stub GetPreviousFgPolicyRefreshInfoInternal
diff --git a/dlls/kernelbase/version.c b/dlls/kernelbase/version.c
index 4d5a8a4de93..fc35c6c6c3c 100644
--- a/dlls/kernelbase/version.c
+++ b/dlls/kernelbase/version.c
@@ -1604,6 +1604,21 @@ LONG WINAPI /* DECLSPEC_HOTPATCH */ GetPackageFamilyName( HANDLE process, UINT32
     return APPMODEL_ERROR_NO_PACKAGE;
 }

+/***********************************************************************
+ *         GetPackagesByPackageFamily   (kernelbase.@)
+ */
+LONG WINAPI /* DECLSPEC_HOTPATCH */ GetPackagesByPackageFamily(const WCHAR *family_name, UINT32 *count, 
+                                                               WCHAR *full_names, UINT32 *buffer_len, WCHAR *buffer)
+{
+    FIXME( "(%s %p %p %p %p): stub\n", debugstr_w(family_name), count, full_names, buffer_len, buffer );
+
+    if (!count || !buffer_len)
+        return ERROR_INVALID_PARAMETER;
+
+    *count = 0;
+    *buffer_len = 0;
+    return ERROR_SUCCESS;
+}

static const struct
 {

[PATCH v4 1/1] kernelbase: Add GetPackagesByPackageFamily stub.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=132237

Your paranoid android.

=== debian11 (32 bit report) ===

d3d9:
device.c:4216: Test failed: Got unexpected screen size 640x480.
device.c:4251: Test failed: Got unexpected screen size 640x480.
device.c:4268: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=0.
device.c:4276: Test failed: Got unexpected width 640.
device.c:4277: Test failed: Got unexpected height 480.
device.c:4358: Test failed: Expected message 0x7e for window 0x1, but didn't receive it, i=0.
device.c:4216: Test failed: Got unexpected screen size 640x480.
device.c:4251: Test failed: Got unexpected screen size 640x480.
device.c:4268: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=1.
device.c:4276: Test failed: Got unexpected width 640.
device.c:4277: Test failed: Got unexpected height 480.
device.c:4358: Test failed: Expected message 0x7e for window 0x1, but didn't receive it, i=1.
device.c:5350: Test failed: Got a different mode.
device.c:5353: Test failed: Got a different mode.
device.c:5470: Test failed: Expected resolution 1024x737, got 640x480.
device.c:5500: Test failed: Expected resolution 1024x737, got 640x480.
device.c:5523: Test failed: Got a different mode.

ddraw:
ddraw2.c:4511: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call
ddraw2.c:4524: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call
ddraw2.c:4540: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence
ddraw2.c:4559: Test failed: Display mode restored after ddraw1-ddraw2 SetCooperativeLevel() call sequence
ddraw4.c:5648: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call
ddraw4.c:5661: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call
ddraw4.c:5677: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence
ddraw4.c:5696: Test failed: Display mode restored after ddraw1-ddraw4 SetCooperativeLevel() call sequence
ddraw7.c:5355: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call
ddraw7.c:5368: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call
ddraw7.c:5384: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence
ddraw7.c:5403: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence