[PATCH 0/1] MR2851: localspl: Fix wow64_start_doc Wow64 entry point.

[PATCH 1/1] localspl: Fix wow64_start_doc Wow64 entry point.

[Piotr Caban]

From: Piotr Caban

---
 dlls/localspl/cups.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/localspl/cups.c b/dlls/localspl/cups.c
index cd2fc0301ba..8ef25c71157 100644
--- a/dlls/localspl/cups.c
+++ b/dlls/localspl/cups.c
@@ -520,9 +520,9 @@ static NTSTATUS wow64_start_doc(void *args)
     struct
     {
         unsigned int type;
-        const PTR32 port;
-        const PTR32 document_title;
-        INT64 *doc;
+        PTR32 port;
+        PTR32 document_title;
+        PTR32 doc;
     } const *params32 = args;

struct start_doc_params params =
@@ -530,7 +530,7 @@ static NTSTATUS wow64_start_doc(void *args)
         params32->type,
         ULongToPtr(params32->port),
         ULongToPtr(params32->document_title),
-        params32->doc,
+        ULongToPtr(params32->doc),
     };

return start_doc(&params);
@@ -541,7 +541,7 @@ static NTSTATUS wow64_write_doc(void *args)
     struct
     {
         INT64 doc;
-        const PTR32 buf;
+        PTR32 buf;
         unsigned int size;
     } const *params32 = args;

[PATCH 1/1] localspl: Fix wow64_start_doc Wow64 entry point.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=132810

Your paranoid android.

=== debian11 (32 bit report) ===

winhttp:
notification.c:118: Test failed: 994: expected status 0x20000 got 0x4000
notification.c:118: Test failed: 994: expected status 0x20000 got 0x1
notification.c:123: Test failed: 994: expected callback 0x1 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x2
notification.c:123: Test failed: 994: expected callback 0x2 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x4
notification.c:123: Test failed: 994: expected callback 0x4 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x8
notification.c:123: Test failed: 994: expected callback 0x8 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x10
notification.c:123: Test failed: 994: expected callback 0x10 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x20
notification.c:123: Test failed: 994: expected callback 0x20 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x40
notification.c:123: Test failed: 994: expected callback 0x40 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x80
notification.c:123: Test failed: 994: expected callback 0x80 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x4000
notification.c:123: Test failed: 994: expected callback 0x4000 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x10
notification.c:123: Test failed: 994: expected callback 0x10 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x20
notification.c:123: Test failed: 994: expected callback 0x20 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x40
notification.c:123: Test failed: 994: expected callback 0x40 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x80
notification.c:123: Test failed: 994: expected callback 0x80 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x4000
notification.c:123: Test failed: 994: expected callback 0x4000 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x10
notification.c:123: Test failed: 994: expected callback 0x10 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x20
notification.c:123: Test failed: 994: expected callback 0x20 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x40
notification.c:123: Test failed: 994: expected callback 0x40 to be called from the same thread
notification.c:118: Test failed: 994: expected status 0x20000 got 0x80
notification.c:123: Test failed: 994: expected callback 0x80 to be called from the same thread
notification.c:123: Test failed: 994: expected callback 0x20000 to be called from the same thread
notification.c:1174: Test failed: got 400
notification.c:118: Test failed: 1181: expected status 0x80000 got 0x200000
notification: Timeout
winhttp.c:3543: Test failed: got 8
winhttp.c:3549: Test failed: got 12019
winhttp.c:3550: Test failed: got 3735928559
Unhandled exception: page fault on write access to 0x00000008 in 32-bit code (0x63c04786).

[PATCH 0/1] MR2851: localspl: Fix wow64_start_doc Wow64 entry point. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.