[PATCH v2 0/1] MR5123: kernel32/tests: Fix console test with odd-sized consoles.

[Jinoh Kang (＠iamahuman)]

--
  v2: kernel32/tests: Fix console test with odd-sized consoles.

https://gitlab.winehq.org/wine/wine/-/merge_requests/5123

[PATCH v2 1/1] kernel32/tests: Fix console test with odd-sized consoles.

[Jinoh Kang]

From: Jinoh Kang

---
 dlls/kernel32/tests/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c
index 2904a31d014..8fadc624e05 100644
--- a/dlls/kernel32/tests/process.c
+++ b/dlls/kernel32/tests/process.c
@@ -545,8 +545,8 @@ static void     doChild(const char* file, const char* option)
         ok( ret, "Setting mode (%ld)\n", GetLastError());
         ret = SetConsoleMode(hConOut, modeOut ^ 1);
         ok( ret, "Setting mode (%ld)\n", GetLastError());
-        sbi.dwCursorPosition.X ^= 1;
-        sbi.dwCursorPosition.Y ^= 1;
+        sbi.dwCursorPosition.X = !sbi.dwCursorPosition.X;
+        sbi.dwCursorPosition.Y = !sbi.dwCursorPosition.Y;
         ret = SetConsoleCursorPosition(hConOut, sbi.dwCursorPosition);
         ok( ret, "Setting cursor position (%ld)\n", GetLastError());
     }

[Jinoh Kang (＠iamahuman)]

On Tue Feb 20 16:02:46 2024 +0000, Jinoh Kang wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5123/diffs?diff_id=100718&start_sha=406fecaa4b46dcf9e38f73e47707a776daac17b1#5039e127257ddb528e569299a8dd9c5f204f5083_549_548)

Applied the suggestion, although 0-sized console will still fail the test.

[eric pouech (＠epo)]

For the record, I made further tests and it looks like native prevents the creation of a console sb smaller than default sb size (from registry)
I'll send a fix later on to prevent Wine's from allowing 0 sized consoles