Here are a few more high-level comments I have:
* I'd like to see more tests for how paths are translated, in particular I'd like to see tests for a DOS-style absolute path name (beginning with a drive letter) and an NT-style absolute path name [i.e. whatever RtlDosPathNameToNtPathName() returns for the same path], and a path containing a single or double dot. I'd also like to see the result of getsockname() on all tested paths.
* I'd also like to see tests for sendto/recvfrom, if for no other reason than to make sure that the address translation is being done there.
* What protocol do these sockets actually have? I.e. what does SO_PROTOCOL_INFO return for them? 0 is usually a wildcard.
* I'm willing to assume that most socket functions probably work the same way (I honestly suspect that's not actually the case, but it's better just to leave that alone for now). That said, tests for any functions that your program uses and depends on would be good, lest we find out later that they're supposed to be implemented differently and break things.
-
Zebediah Figura (＠zfigura)