Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().

[Zebediah Figura (＠zfigura)]

On Thu May 18 20:23:30 2023 +0000, Ethan Lee wrote:
> This change seems like it would break the result - do we want it to be
> more like
> bool success = true;
> ...
>             case HLSL_TYPE_INT:
>                 /* Always evaluate this expression... */
>                 dst->value.u[k].i = abs(src->value.u[k].i);
>                 /* ... but if we try abs(INT_MIN), mark this fold as
> invalid */
>                 if (src->value.u[k].i == INT_MIN)
>                 {
>                     success = false;
>                 }
>                 break;
> ...
> return success;

I don't understand, why would it break the result?