Re: [PATCH v6 0/4] MR5161: d3drm: Implement Update and related functions

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/d3drm/viewport.c:
> - FIXME("iface %p, x1 %lu, y1 %lu, x2 %lu, y2 %lu stub!\n", iface, x1, y1, x2, y2);
> - struct d3drm_viewport *viewport = impl_from_IDirect3DRMViewport2(iface);
> - D3DVIEWPORT vp = { sizeof(vp) };
> - HRESULT hr;
> - return E_NOTIMPL;
> - TRACE("iface %p, x1 %lu, y1 %lu, x2 %lu, y2 %lu.\n", iface, x1, y1, x2, y2);
> -
> - if (!viewport->d3d_viewport)
> -
>    return D3DRMERR_BADOBJECT;
> -
> - if (FAILED(hr = IDirect3DViewport_GetViewport(viewport->d3d_viewport, &vp)))
> -
>    return hr;
> -
> - if (x1 > x2 || y1 > y2 || x1 < vp.dwX || y1 < vp.dwY ||
> -
>        x2 > (vp.dwX + vp.dwWidth) || y2 > (vp.dwY + vp.dwHeight))

It'd be nice to rename these parameters to left/right/top/bottom.