[PATCH 0/1] MR5959: ntdll: Prevent double close in error case (coverity)

[Fabian Maurer (＠DarkShadow44)]

If we do a break, fd might be closed again

[PATCH 1/1] ntdll: Prevent double close in error case (coverity)

[Fabian Maurer]

From: Fabian Maurer

If we do a break, fd might be closed again
---
 dlls/ntdll/unix/socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/ntdll/unix/socket.c b/dlls/ntdll/unix/socket.c
index a2b7b9fd051..90405e005f0 100644
--- a/dlls/ntdll/unix/socket.c
+++ b/dlls/ntdll/unix/socket.c
@@ -1787,8 +1787,7 @@ NTSTATUS sock_ioctl( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, void *apc

if (getifaddrs( &ifaddrs ) < 0)
             {
-                status = sock_errno_to_status( errno );
-                break;
+                return sock_errno_to_status( errno );
             }

for (ifaddr = ifaddrs; ifaddr != NULL; ifaddr = ifaddr->ifa_next)

[Fabian Maurer (＠DarkShadow44)]

Any news?

[Akihiro Sagawa (＠sgwaki)]

From my review of the code, although I am not a maintainer, this looks good to me.