Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c:
- ok( status == STATUS_SUCCESS, "got %#lx\n", status );
- ok( attrs & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", attrs );
- todo_wine ok( !(attrs & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", attrs );
- status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation );
- ok( status == STATUS_SUCCESS, "got %#lx\n", status );
- ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes );
- ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes );
- CloseHandle( h );
- GetTempPathW( MAX_PATH, temppathW );
- GetTempFileNameW( temppathW, L"foo", 0, filenameW );
- h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 );
- ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" );
- if (h == INVALID_HANDLE_VALUE) return;
Similarly here, better to get rid of the return entirely.