[PATCH v2 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH.

[Dmitry Timoshkov (＠dmitry)]

--
  v2: kerberos: Add support for SECPKG_CRED_BOTH.

https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

[PATCH v2 1/1] kerberos: Add support for SECPKG_CRED_BOTH.

[Dmitry Timoshkov]

From: Dmitry Timoshkov

Signed-off-by: Dmitry Timoshkov 
---
 dlls/kerberos/unixlib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/kerberos/unixlib.c b/dlls/kerberos/unixlib.c
index 5bc1f72981f..a7cb8b1da7a 100644
--- a/dlls/kerberos/unixlib.c
+++ b/dlls/kerberos/unixlib.c
@@ -654,13 +654,13 @@ static NTSTATUS acquire_credentials_handle( void *args )
         cred_usage = GSS_C_ACCEPT;
         break;

+    case SECPKG_CRED_BOTH:
     case SECPKG_CRED_OUTBOUND:
         if ((status = init_creds( params->username, params->password )) != STATUS_SUCCESS) return status;
-        cred_usage = GSS_C_INITIATE;
+        cred_usage = params->credential_use == SECPKG_CRED_OUTBOUND ? GSS_C_INITIATE : GSS_C_BOTH;
         break;

default:
-        FIXME( "SECPKG_CRED_BOTH not supported\n" );
         return SEC_E_UNKNOWN_CREDENTIALS;
     }

[PATCH v2 1/1] kerberos: Add support for SECPKG_CRED_BOTH.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=146884

Your paranoid android.

=== debian11b (64 bit WoW report) ===

user32:
win.c:4037: Test failed: Expected active window 000000000351015C, got 00000000041B016C.
win.c:4038: Test failed: Expected focus window 000000000351015C, got 00000000041B016C.

[Dmitry Timoshkov (＠dmitry)]

On Mon Jul  8 19:33:28 2024 +0000, Hans Leidekker wrote:
> Also note that your patch for msv1_0 does initialize credentials for SECPKG_CRED_BOTH.

Makes sense, thanks.

[PATCH v2 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.