[PATCH 0/1] MR3768: msxml3/tests: Fix failure messages.

[PATCH 1/1] msxml3/tests: Fix failure messages.

[Daniel Lehman]

From: Daniel Lehman

---
 dlls/msxml3/tests/domdoc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index cf9fb62a65e..6590a8dbad4 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -13765,12 +13765,12 @@ static void test_namespaces_as_attributes(void)
                 hr = IXMLDOMNode_get_prefix(item, &str);
                 if (test->prefixes[i])
                 {
-                    ok(hr == S_OK, "Failed to get node name, hr %#lx.\n", hr);
+                    ok(hr == S_OK, "Failed to get prefix, hr %#lx.\n", hr);
                     ok(!lstrcmpW(str, _bstr_(test->prefixes[i])), "got %s\n", wine_dbgstr_w(str));
                     SysFreeString(str);
                 }
                 else
-                    ok(hr == S_FALSE, "Failed to get node name, hr %#lx.\n", hr);
+                    ok(hr == S_FALSE, "Unexpected hr %#lx.\n", hr );

str = NULL;
                 hr = IXMLDOMNode_get_baseName(item, &str);
@@ -13782,7 +13782,7 @@ static void test_namespaces_as_attributes(void)
                 hr = IXMLDOMNode_get_namespaceURI(item, &str);
                 if (test->uris[i])
                 {
-                    ok(hr == S_OK, "Failed to get node name, hr %#lx.\n", hr);
+                    ok(hr == S_OK, "Failed to get namespace URI, hr %#lx.\n", hr);
                     if (test->prefixes[i] && !strcmp(test->prefixes[i], "xmlns"))
                         ok(!lstrcmpW(str, _bstr_(entry->xmlns_uri)), "got %s\n", wine_dbgstr_w(str));
                     else
@@ -13790,7 +13790,7 @@ static void test_namespaces_as_attributes(void)
                     SysFreeString(str);
                 }
                 else
-                    ok(hr == S_FALSE, "Failed to get node name, hr %#lx.\n", hr);
+                    ok(hr == S_FALSE, "Unexpected hr %#lx.\n", hr );

str = NULL;
                 hr = IXMLDOMNode_get_text(item, &str);

[Nikolay Sivov (＠nsivov)]

This could be using generic "unexpected hr" message too, so we don't have to change it ever again.

[PATCH 0/1] MR3768: msxml3/tests: Fix failure messages. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.