Log: The flag that bNoItemMetrics needs to be reset to TRUE after
call func LISTVIEW_DeleteAllItems.
Signed-off-by: Zhao Yi zhaoyi@uniontech.com
From: Zhao Yi zhaoyi@uniontech.com
Log: The flag that bNoItemMetrics needs to be reset to TRUE after
call func LISTVIEW_DeleteAllItems.
Signed-off-by: Zhao Yi zhaoyi@uniontech.com --- dlls/comctl32/listview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index 750e447dbef..026884372aa 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -5590,7 +5590,7 @@ static BOOL LISTVIEW_DeleteAllItems(LISTVIEW_INFO *infoPtr, BOOL destroy) LISTVIEW_UpdateScroll(infoPtr); } LISTVIEW_InvalidateList(infoPtr); - + infoPtr->bNoItemMetrics = TRUE; return TRUE; }
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c:
LISTVIEW_UpdateScroll(infoPtr); } LISTVIEW_InvalidateList(infoPtr);
- infoPtr->bNoItemMetrics = TRUE;
The change is reasonable. To verify this, could you provide an example for trigger an occasion when item metrics should have been recalculated?
Also, there are some grammar errors in your commit message. You can say "bNoItemMetrics should be reset to TRUE after calling LISTVIEW_DeleteAllItems()."
On Tue Mar 14 09:09:40 2023 +0000, Zhiyi Zhang wrote:
The change is reasonable. To verify this, could you provide an example for trigger an occasion when item metrics should have been recalculated? Also, there are some grammar errors in your commit message. You can say "bNoItemMetrics should be reset to TRUE after calling LISTVIEW_DeleteAllItems()."
Sorry! My English is a little poor ^v^. Next,I will give an example to explain why we need to modify it this way: a-Fonts folder there are three files：a folder、b folder and 1.jpg,Use the app "2345 View Manager" in Windows can display all the items as shown below:  But use the app "2345 View Manager" in wine cannot display all the items as shown below:  After debugging and analysis, it is finally located because the function LISTVIEW_paint logic does not meet the condition infoPtr ->bNoItemMetrics=true, as shown in the figure below:  which results in the same calculation of the location of each file, so the phenomenon we finally see is that only one file is displayed
On Tue Mar 14 09:52:20 2023 +0000, Zhao Yi wrote:
Sorry! My English is a little poor ^v^. Next,I will give an example to explain why we need to modify it this way: a-Fonts folder there are three files：a folder、b folder and 1.jpg,Use the app "2345 View Manager" in Windows can display all the items as shown below:  But use the app "2345 View Manager" in wine cannot display all the items as shown below:  After debugging and analysis, it is finally located because the function LISTVIEW_paint logic does not meet the condition infoPtr ->bNoItemMetrics=true, as shown in the figure below:  which results in the same calculation of the location of each file, so the phenomenon we finally see is that only one file is displayed
LISTVIEW_DeleteAllItems() function will be triggered when we click a new folder, for example, LISTVIEW_DeleteAllItems() function will be triggered after clicking the folder a-Fonts.
On Wed Mar 15 01:27:12 2023 +0000, Zhao Yi wrote:
LISTVIEW_DeleteAllItems() function will be triggered when we click a new folder, for example, LISTVIEW_DeleteAllItems() function will be triggered after clicking the folder a-Fonts.
I see. Please update your commit message as I said and I will approve this. Thanks.
On Wed Mar 15 09:27:38 2023 +0000, Zhiyi Zhang wrote:
I see. Please update your commit message as I said and I will approve this. Thanks.
OK. Thank you for your review. I will update the commit message later.
This merge request was closed by Zhao Yi.
-
Zhao Yi -
Zhao Yi (＠Zhaoyi)
-
Zhiyi Zhang (＠zhiyi)