Re: [PATCH v19 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)

[Felix Münchhalfen (＠jfmu)]

On Wed Jan 31 00:51:30 2024 +0000, Alexandre Julliard wrote:
> The tests fail on 64-bit:
> ../wine/tools/runtest -q -P wine -T . -M kernelbase.dll -p
> dlls/kernelbase/tests/x86_64-windows/kernelbase_test.exe process &&
> touch dlls/kernelbase/tests/x86_64-windows/process.ok
> process.c:156: Test failed: VirtualFree failed to split the placeholder 487
> process.c:160: Test failed: MapViewOfFile3 did not map the file mapping 87
> process.c:163: Test failed: UnmapViewOfFile failed 487
> process.c:185: Test failed: VirtualFree of remaining region failed
> make: *** [Makefile:91467:
> dlls/kernelbase/tests/x86_64-windows/process.ok] Error 4

Oh! To my shame i must admit i tested this with wine-staging patches applied. There is one patch in there that modifies   how views are handled.

But anyways, i fixed the tests now, and i believe using VirtualFree in that way is more correct.

I was just curious before, if it would be possible to split a big placeholder allocation into two, with a hole in the middle. But when i think about it, i dont think that this is how it's supposed to work. You would rather have to start chewing off a big placeholder from the start to the end. Please test again now.