Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2

[Anton Baskanov (＠baskanov)]

On Mon Nov 13 13:16:56 2023 +0000, Rémi Bernon wrote:
> Instead of a dynamic list, could we have just a simple structure like:
> struct gen_increments
> {
>     float env_hold;
>     float env_decay;
>     float vol_hold;
>     float vol_decay;
> };
>
> Which we would pass around down to `add_mod_from_connection` which would
> set the needed adjustments (it's actually only needed there,
> `set_gen_from_connection` won't have to add increments), and then after
> the loops we would call `fluid_voice_gen_incr` for each of these?
> Or do we need the generic version for more fixups that are not in this MR?

If we don't need to support arbitrary connections, then yes, your proposed solution looks like the way to go.

I don't currently plan to add more fixups.