[PATCH 0/1] MR5284: secur32: Replace sprintf with snprintf to avoid deprecation warnings on macOS.

[PATCH 1/1] secur32: Replace sprintf with snprintf to avoid deprecation warnings on macOS.

[Brendan Shanks]

From: Brendan Shanks

---
 dlls/secur32/schannel_gnutls.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c
index 600b0d0166a..fc16ded7a64 100644
--- a/dlls/secur32/schannel_gnutls.c
+++ b/dlls/secur32/schannel_gnutls.c
@@ -401,7 +401,7 @@ static void check_supported_protocols(

for(i = 0; i < num_flags; i++)
     {
-        sprintf(priority, "NORMAL:-%s", flags[i].gnutls_flag);
+        snprintf(priority, sizeof(priority), "NORMAL:-%s", flags[i].gnutls_flag);
         err = pgnutls_priority_set_direct(session, priority, NULL);
         if (err == GNUTLS_E_SUCCESS)
         {
@@ -1022,7 +1022,7 @@ static NTSTATUS schan_get_cipher_info( void *args )
     wcscat( info->szCipherSuite, widthW );
     wcscat( info->szCipherSuite, info->szCipher );
     wcscat( info->szCipherSuite, underscoreW );
-    len = sprintf( buf, "%u", (unsigned int)info->dwCipherLen ) + 1;
+    len = snprintf( buf, sizeof(buf), "%u", (unsigned int)info->dwCipherLen ) + 1;
     ptr = info->szCipherSuite + wcslen( info->szCipherSuite );
     ntdll_umbstowcs( buf, len, ptr, len );
     wcscat( info->szCipherSuite, underscoreW );

[PATCH 1/1] secur32: Replace sprintf with snprintf to avoid deprecation warnings on macOS.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=143971

Your paranoid android.

=== debian11 (32 bit report) ===

secur32:
schannel.c:538: Test failed: cert_cnt = 2

=== debian11b (64 bit WoW report) ===

secur32:
schannel.c:538: Test failed: cert_cnt = 2