This test currently hit a Metal bug when run on Apple Silicon with MoltenVK and fails. We don't have an easy way to mark shader runner tests as buggy and we're not interested in tracking that bug anyway, so I'm just working around it.
From: Giovanni Mascellani gmascellani@codeweavers.com
This test currently hit a Metal bug when run on Apple Silicon with MoltenVK and fails. We don't have an easy way to mark shader runner tests as buggy and we're not interested in tracking that bug anyway, so I'm just working around it. --- tests/hlsl/switch.shader_test | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/hlsl/switch.shader_test b/tests/hlsl/switch.shader_test index 01624f97c..f124f38f3 100644 --- a/tests/hlsl/switch.shader_test +++ b/tests/hlsl/switch.shader_test @@ -527,7 +527,7 @@ float4 main() : sv_target { switch (v.x) { - case 0: + case 1: for (j = 0; j < v.z; j++) { c += 1.0f; @@ -535,7 +535,7 @@ float4 main() : sv_target continue; } break; - case 1: + case 0: c += 2.0f; break; } @@ -545,10 +545,10 @@ float4 main() : sv_target }
[test] -uniform 0 uint4 0 0 3 1 +uniform 0 uint4 1 0 3 1 todo(sm>=6) draw quad probe all rgba (10.0, 11.0, 12.0, 13.0) -uniform 0 uint4 1 0 3 1 +uniform 0 uint4 0 0 3 1 todo(sm>=6) draw quad probe all rgba (7.0, 8.0, 9.0, 10.0)
This merge request was approved by Giovanni Mascellani.
We don't have an easy way to mark shader runner tests as buggy and we're not interested in tracking that bug anyway, so I'm just working around it.
I think this is fine, but if it helps, it wouldn't be too hard to add support for something like "bug(mvk)". I have most of what's needed as part of my GLSL tree.
This conflicts with !607 in any case though.
On Tue Feb 6 11:48:04 2024 +0000, Henri Verbeet wrote:
We don't have an easy way to mark shader runner tests as buggy and
we're not interested in tracking that bug anyway, so I'm just working around it. I think this is fine, but if it helps, it wouldn't be too hard to add support for something like "bug(mvk)". I have most of what's needed as part of my GLSL tree. This conflicts with !607 in any case though.
I think the main point here is that it's not a bug I'm particularly interested into tracking. I don't think it provides any useful value to vkd3d.
I think the main point here is that it's not a bug I'm particularly interested into tracking. I don't think it provides any useful value to vkd3d.
Sure; just pointing out that I have some patches that may help if we need something like "bug(mvk)" anywhere else.
-
Giovanni Mascellani -
Giovanni Mascellani (＠giomasce)
-
Henri Verbeet (＠hverbeet)