[PATCH 0/1] MR2935: include: Fix the use of __getReg for aarch64/msvc mode

[Martin Storsjö (＠mstorsjo)]

Clang requires the __getReg function to be declared in addition to
be declared as an intrinsic with the pragma.

This fixes the following error:

../wine/include/winnt.h:2412:27: error: call to undeclared library function '__getReg' with type 'unsigned long long (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    return (struct _TEB *)__getReg(18);
                          ^
../wine/include/winnt.h:2412:27: note: include the header <intrin.h> or explicitly provide a declaration for '__getReg'
1 error generated.

Signed-off-by: Martin Storsjö

[PATCH 1/1] include: Fix the use of __getReg for aarch64/msvc mode

[Martin Storsjö]

From: Martin Storsjö

Clang requires the __getReg function to be declared in addition to
be declared as an intrinsic with the pragma.

This fixes the following error:

../wine/include/winnt.h:2412:27: error: call to undeclared library function '__getReg' with type 'unsigned long long (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    return (struct _TEB *)__getReg(18);
                          ^
../wine/include/winnt.h:2412:27: note: include the header <intrin.h> or explicitly provide a declaration for '__getReg'
1 error generated.

Signed-off-by: Martin Storsjö 
---
 include/winnt.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/winnt.h b/include/winnt.h
index 0117100a921..409dbceee59 100644
--- a/include/winnt.h
+++ b/include/winnt.h
@@ -2406,6 +2406,7 @@ static FORCEINLINE struct _TEB * WINAPI NtCurrentTeb(void)
     return __wine_current_teb;
 }
 #elif defined(__aarch64__) && defined(_MSC_VER)
+unsigned __int64 __getReg(int);
 #pragma intrinsic(__getReg)
 static FORCEINLINE struct _TEB * WINAPI NtCurrentTeb(void)
 {

[Brendan Shanks (＠bshanks)]

Should the prototype be added to `include/msvcrt/intrin.h` instead?

[Martin Storsjö (＠mstorsjo)]

On Wed May 31 19:51:32 2023 +0000, Brendan Shanks wrote:
> Should the prototype be added to `include/msvcrt/intrin.h` instead?

Dunno, we seem to use this pattern with declaring these intrinsics right here for other architectures too (see `__readgsqword` for x86_64 right above). Curiously, `_MoveFromCoprocessor` doesn't seem to require a prototype, the pragma is enough - I tested that one too.

[Alexandre Julliard (＠julliard)]

Indeed, it seems that all these prototypes should go into intrin.h. This can be a separate MR though.