[PATCH 0/1] MR6412: winecoreaudio: Set the synth volume to the greater of the left and right channels.

[PATCH 1/1] winecoreaudio: Set the synth volume to the greater of the left and right channels.

[Huw Davies]

From: Huw Davies

---
 dlls/winecoreaudio.drv/coremidi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/winecoreaudio.drv/coremidi.c b/dlls/winecoreaudio.drv/coremidi.c
index 37cf859a913..9b1fbd28f6a 100644
--- a/dlls/winecoreaudio.drv/coremidi.c
+++ b/dlls/winecoreaudio.drv/coremidi.c
@@ -857,7 +857,8 @@ static UINT midi_out_set_volume(WORD dev_id, UINT volume)
         left  = LOWORD(volume) / 65535.0f;
         right = HIWORD(volume) / 65535.0f;

-        AudioUnitSetParameter(dests[dev_id].synth, kHALOutputParam_Volume, kAudioUnitParameterFlag_Output, 0, left, 0);
+        AudioUnitSetParameter(dests[dev_id].synth, kHALOutputParam_Volume, kAudioUnitParameterFlag_Output,
+                              0, fmaxf(left, right), 0);
         return MMSYSERR_NOERROR;
     }

[Elizabeth Figura (＠zfigura)]

Not my wheelhouse, but I'm curious what's the motivation here. Would the average make more sense?

[Huw Davies (＠huw)]

On Fri Aug 30 16:51:36 2024 +0000, Elizabeth Figura wrote:
> Not my wheelhouse, but I'm curious what's the motivation here. Would the
> average make more sense?

I figured hearing something had more use than silence, so using the higher of the two seemed to make more sense.