[PATCH v2 0/1] MR4530: d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC).

[Alex Henrie (＠alexhenrie)]

--
  v2: d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC).

https://gitlab.winehq.org/wine/wine/-/merge_requests/4530

[PATCH v2 1/1] d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC).

[Alex Henrie]

From: Alex Henrie

---
 dlls/d3drm/texture.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3drm/texture.c b/dlls/d3drm/texture.c
index f0983d53e24..0922837255c 100644
--- a/dlls/d3drm/texture.c
+++ b/dlls/d3drm/texture.c
@@ -153,7 +153,8 @@ static BOOL d3drm_image_palettise(D3DRMIMAGE *image, unsigned char *src_data,
     image->green_mask = 0xff;
     image->blue_mask = 0xff;
     image->palette_size = colour_count;
-    if (!(image->palette = realloc(palette, colour_count * sizeof(*palette))))
+    image->palette = palette;
+    if ((palette = realloc(palette, colour_count * sizeof(*palette))))
         image->palette = palette;

return TRUE;

[PATCH v2 0/1] MR4530: d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC). - approved

[Jan Sikorski (＠jsikorski)]

This merge request was approved by Jan Sikorski.

[PATCH v2 0/1] MR4530: d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC). - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.