On Tue Nov 21 15:10:16 2023 +0000, Rémi Bernon wrote:
I suspect this is actually related to the tests using WMAUDIO2 (aka WMAudioV8), which, if I believe the headers files, where WMAUDIO_BITS_PER_SAMPLE is used, only supports 16bps. The bps is then automatically set and the media type doesn't need one. Also from the headers, I suspect WMAUDIO3 may support variable bps which maybe would require changes here and in other places where we use a fixed value. All of which may require more tests to be sure. Which probably could be added later.
Yes, more tests always help. But GStreamer/ffmpeg don't have any WMA3/WMALossless/WMV3/WMVA/WVC1 encoders, and Windows' media APIs are _complicated_, so I couldn't produce any suitable test files.
Probably not a huge deal which output format we use, we've got audioconvert elements. But there's also no point hardcoding things when there's a depth field in struct wg_format; fixed.
-
Alfred Agrell (＠Alcaro)