This is first MR part of a larger plan [1].
Native by default clears the std handles on process creation for an image belonging to the GUI subsystem, but Wine doesn't.
This can lead to some issues (eg. https://bugs.winehq.org/show_bug.cgi?id=55439)
Several steps: - correct some erroneous subsystems definition for builtin programs (this MR) - fix builtin programs, declared in GUI subsystem, but still incorrectly use console/file oriented APIs - fix CreateProcess
[1] https://gitlab.winehq.org/epo/wine/-/tree/mr-console?ref_type=heads
From: Eric Pouech epouech@codeweavers.com
Signed-off-by: Eric Pouech epouech@codeweavers.com --- programs/dpnsvr/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/dpnsvr/Makefile.in b/programs/dpnsvr/Makefile.in index a1e31ab7d51..5aa3c76f199 100644 --- a/programs/dpnsvr/Makefile.in +++ b/programs/dpnsvr/Makefile.in @@ -1,6 +1,6 @@ MODULE = dpnsvr.exe
-EXTRADLLFLAGS = -mconsole -municode +EXTRADLLFLAGS = -mwindows -municode
SOURCES = \ main.c \
From: Eric Pouech epouech@codeweavers.com
Signed-off-by: Eric Pouech epouech@codeweavers.com --- programs/spoolsv/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/spoolsv/Makefile.in b/programs/spoolsv/Makefile.in index 6ec2a5e2b4d..1fd76e6d59b 100644 --- a/programs/spoolsv/Makefile.in +++ b/programs/spoolsv/Makefile.in @@ -1,7 +1,7 @@ MODULE = spoolsv.exe IMPORTS = advapi32
-EXTRADLLFLAGS = -mconsole +EXTRADLLFLAGS = -mwindows
SOURCES = \ main.c
From: Eric Pouech epouech@codeweavers.com
Signed-off-by: Eric Pouech epouech@codeweavers.com --- programs/svchost/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/svchost/Makefile.in b/programs/svchost/Makefile.in index 8a1d648df0f..53288b3694b 100644 --- a/programs/svchost/Makefile.in +++ b/programs/svchost/Makefile.in @@ -1,7 +1,7 @@ MODULE = svchost.exe IMPORTS = advapi32
-EXTRADLLFLAGS = -mconsole -municode +EXTRADLLFLAGS = -mwindows -municode
SOURCES = \ svchost.c
From: Eric Pouech epouech@codeweavers.com
Signed-off-by: Eric Pouech epouech@codeweavers.com --- programs/services/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/services/Makefile.in b/programs/services/Makefile.in index 735fb6ec886..c314b467d0a 100644 --- a/programs/services/Makefile.in +++ b/programs/services/Makefile.in @@ -1,7 +1,7 @@ MODULE = services.exe IMPORTS = rpcrt4 advapi32 userenv setupapi
-EXTRADLLFLAGS = -mconsole +EXTRADLLFLAGS = -mwindows
SOURCES = \ rpc.c \