[PATCH v3 0/1] MR1960: localspl: Avoid uninitialized variable in fill_builtin_form_info

[Gerald Pfeifer (＠gerald)]

As diagnosed by GCC 13:

dlls/localspl/provider.c: In function ‘fill_builtin_form_info’:
    dlls/localspl/provider.c:3045:16: warning: ‘res_len’ may be used uninitialized [-Wmaybe-uninitialized]
     3045 |             if (res_len)
          |                ^

--
  v3: localspl: Avoid uninitialized variable in fill_builtin_form_info

https://gitlab.winehq.org/wine/wine/-/merge_requests/1960

[PATCH v3 1/1] localspl: Avoid uninitialized variable in fill_builtin_form_info

[Gerald Pfeifer]

From: Gerald Pfeifer

As diagnosed by GCC 13:

dlls/localspl/provider.c: In function ‘fill_builtin_form_info’:
    dlls/localspl/provider.c:3045:16: warning: ‘res_len’ may be used uninitialized [-Wmaybe-uninitialized]
     3045 |             if (res_len)
          |                ^
---
 dlls/localspl/provider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/localspl/provider.c b/dlls/localspl/provider.c
index 790d9d64c00..7ab68b62c3d 100644
--- a/dlls/localspl/provider.c
+++ b/dlls/localspl/provider.c
@@ -3008,7 +3008,7 @@ static void fill_builtin_form_info( BYTE **base, WCHAR **strings, const struct b
                                     DWORD size, DWORD *used )
 {
     FORM_INFO_2W *info = *(FORM_INFO_2W**)base;
-    DWORD name_len = wcslen( form->name ) + 1, res_len, keyword_len, total_size;
+    DWORD name_len = wcslen( form->name ) + 1, res_len = 0, keyword_len, total_size;
     static const WCHAR dll_name[] = L"localspl.dll";
     const WCHAR *resource;

[PATCH v3 1/1] localspl: Avoid uninitialized variable in fill_builtin_form_info

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=128415

Your paranoid android.

=== debian11 (32 bit report) ===

ntoskrnl.exe:
driver_pnp.c:707: Test failed: Got 1 remove events.

[Gerald Pfeifer (＠gerald)]

On Sat Jan 14 00:09:02 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=128414
> Your paranoid android.
> === debian11 (build log) ===
> error: patch failed: tools/wrc/wrc.c:305
> Task: Patch failed to apply
> === debian11b (build log) ===
> error: patch failed: tools/wrc/wrc.c:305
> Task: Patch failed to apply

I believe this was the earlier submission with me doing an incorrect update/submission.

[PATCH v3 0/1] MR1960: localspl: Avoid uninitialized variable in fill_builtin_form_info - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.