Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pecoff.h:
> +ULONG image_rva_to_file_offset(
> - IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PUCHAR image_base, ULONG image_size);
> -
>
> +ULONG image_directory_rva_and_size(
> - IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size,
> - PUCHAR image_base, ULONG image_size);
> -
>
> +ULONG image_directory_offset_and_size(
> - IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size,
> - PUCHAR image_base, ULONG image_size);
> -
>
> +PVOID image_rva_to_mapped_address(
> -
> IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PVOID image_base, ULONG image_size);
> -
>
> +PVOID image_directory_mapped_address(
> - IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, USHORT directory_entry, ULONG *directory_size,

I don't think we need another C or header file for these.