On Wed Sep 18 15:58:22 2024 +0000, Nikolay Sivov wrote:
I think it is, because it will produce incorrect rendering. First priority is to have it working correctly, then we can deal with possible duplication.
TBH, I do not really know what to make of this assessment. Looking at the d2d1 tests it feels like, correctness is at best achieved approximately, and then the question arises what is the metric in which "correctness" is assessed? Unarguably, the tests as a metric are a moving target, depending on when which tests are added, thus making it a subjective choice at times.
In my book, the patch at hand makes the rendering more correct in many cases. To be precise in all cases in which the individual geometries in the geometry group do not intersect, and thus the fill mode does not matter. Would you consider the patch sufficient, if it would (approximately) check for intersections and only copy if there are none, and falling back to old behavior (rendering just nothing) in case there are any (potentially false-positive) intersections?
-
Philipp Knechtges (＠d1saster)