On Tue Jan 14 07:51:31 2025 +0000, Jacek Caban wrote:
Sorry for the delay, I'm not sure what to think about it. If it's dropped in modern Windows, it's not clear if we want it. I guess it wouldn't hurt... We usually add SVGs so that maintainer mode can generate binary blobs. It seems that Tango theme repo contains SVGs, could we use them?
Hi Jacek, thanks for the review. When I wrote this patch, I considered combining the Tango SVGs into a single SVG file that would be converted to a PNG when building in Wine maintainer mode, but it turned out to be more trouble than it was worth. It's trivial to combine PNG files with ImageMagick, whereas combining SVG files requires a lot of manual effort. Moreover, no one cares about modifying these icons or has made an argument for why different icons would be better than the Tango defaults. And if in the future someone decides to import the SVGs into Wine, the resulting PNG will still have to be regenerated and replaced in the Git repository; we have to have a PNG in Git regardless of how it is created.
It seems to me that we either need to merge a patch like the one I am proposing, or we need to close [Bug 40236](https://bugs.winehq.org/show_bug.cgi?id=40236) as WONTFIX and remove the [patches in Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/shell32-Too...). The most important thing is just to make a decision.
-
Alex Henrie (＠alexhenrie)