[PATCH v6 0/3] MR568: vkd3d-shader: Miscellaneous changes in view of the CFG structurizer.

[Giovanni Mascellani (＠giomasce)]

--
  v6:  
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/568

[PATCH v6 1/3] tests: Add a test with non-trivial control flow.

[Giovanni Mascellani]

From: Giovanni Mascellani

---
 tests/hlsl/for.shader_test | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/tests/hlsl/for.shader_test b/tests/hlsl/for.shader_test
index 9407c81bc..7abd20672 100644
--- a/tests/hlsl/for.shader_test
+++ b/tests/hlsl/for.shader_test
@@ -28,6 +28,40 @@ probe (  0, 0, 159, 480) rgba (10.0, 35.0, 0.0, 0.0)
 probe (161, 0, 479, 480) rgba (10.0, 38.0, 0.0, 0.0)
 probe (481, 0, 640, 480) rgba ( 5.0, 10.0, 0.0, 0.0)

+[require]
+shader model >= 4.0
+
+% Identical to the previous, except we prevent DXC from unrolling the
+% loop so we can test non-trivial control flow
+[pixel shader]
+uniform uint iter;
+
+float4 main(float tex : texcoord) : sv_target
+{
+    int i;
+    float x = 0.0;
+    for (i = 0; i < iter; i++)
+    {
+        x += i;
+        if (tex > 0.5 && i == 5)
+            break;
+        if (tex > -0.5 && i >= 7)
+            continue;
+        x -= 1;
+    }
+    return float4(i, x, 0.0, 0.0);
+}
+
+[test]
+uniform 0 uint4 10 0 0 0
+todo(sm>=6) draw quad
+probe (  0, 0, 159, 480) rgba (10.0, 35.0, 0.0, 0.0)
+probe (161, 0, 479, 480) rgba (10.0, 38.0, 0.0, 0.0)
+probe (481, 0, 640, 480) rgba ( 5.0, 10.0, 0.0, 0.0)
+
+[require]
+% Reset requirements
+
 [pixel shader]
 float4 main(float tex : texcoord) : sv_target
 {

[PATCH v6 2/3] tests: Test a couple of degenerate switch instances.

[Giovanni Mascellani]

From: Giovanni Mascellani

---
 tests/hlsl/switch.shader_test | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/tests/hlsl/switch.shader_test b/tests/hlsl/switch.shader_test
index b7edadccf..01624f97c 100644
--- a/tests/hlsl/switch.shader_test
+++ b/tests/hlsl/switch.shader_test
@@ -28,6 +28,41 @@ uniform 0 uint4 0 0 0 0
 draw quad
 probe all rgba (3.0, 3.0, 3.0, 3.0)

+% just a default case
+[pixel shader]
+uint4 v;
+
+float4 main() : sv_target
+{
+    switch (v.x)
+    {
+    default:
+        return 5.0;
+    }
+}
+
+[test]
+uniform 0 uint4 3 0 0 0
+draw quad
+probe all rgba (5.0, 5.0, 5.0, 5.0)
+uniform 0 uint4 1 0 0 0
+draw quad
+probe all rgba (5.0, 5.0, 5.0, 5.0)
+uniform 0 uint4 0 0 0 0
+draw quad
+probe all rgba (5.0, 5.0, 5.0, 5.0)
+
+% completely empty
+[pixel shader fail]
+uint4 v;
+
+float4 main() : sv_target
+{
+    switch (v.x)
+    {
+    }
+}
+
 % falling through is only supported for empty case statements
 [pixel shader]
 uint4 v;

[PATCH v6 3/3] vkd3d-shader: Make relative address sources mutable too.

[Giovanni Mascellani]

From: Giovanni Mascellani

They were forgotten in 78d95889bd49c6028f0c26aaec5589786381da4a.

Fixes: 78d95889bd49c6028f0c26aaec5589786381da4a
---
 libs/vkd3d-shader/d3dbc.c                | 4 ++--
 libs/vkd3d-shader/vkd3d_shader_private.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libs/vkd3d-shader/d3dbc.c b/libs/vkd3d-shader/d3dbc.c
index aa0dd8f4b..dcd510355 100644
--- a/libs/vkd3d-shader/d3dbc.c
+++ b/libs/vkd3d-shader/d3dbc.c
@@ -444,7 +444,7 @@ static uint32_t swizzle_from_sm1(uint32_t swizzle)
             shader_sm1_get_swizzle_component(swizzle, 3));
 }

-static void shader_sm1_parse_src_param(uint32_t param, const struct vkd3d_shader_src_param *rel_addr,
+static void shader_sm1_parse_src_param(uint32_t param, struct vkd3d_shader_src_param *rel_addr,
         struct vkd3d_shader_src_param *src)
 {
     enum vkd3d_shader_register_type reg_type = ((param & VKD3D_SM1_REGISTER_TYPE_MASK) >> VKD3D_SM1_REGISTER_TYPE_SHIFT)
@@ -465,7 +465,7 @@ static void shader_sm1_parse_src_param(uint32_t param, const struct vkd3d_shader
     src->modifiers = (param & VKD3D_SM1_SRC_MODIFIER_MASK) >> VKD3D_SM1_SRC_MODIFIER_SHIFT;
 }

-static void shader_sm1_parse_dst_param(uint32_t param, const struct vkd3d_shader_src_param *rel_addr,
+static void shader_sm1_parse_dst_param(uint32_t param, struct vkd3d_shader_src_param *rel_addr,
         struct vkd3d_shader_dst_param *dst)
 {
     enum vkd3d_shader_register_type reg_type = ((param & VKD3D_SM1_REGISTER_TYPE_MASK) >> VKD3D_SM1_REGISTER_TYPE_SHIFT)
diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h
index 8c5955d3d..4c5f961aa 100644
--- a/libs/vkd3d-shader/vkd3d_shader_private.h
+++ b/libs/vkd3d-shader/vkd3d_shader_private.h
@@ -826,7 +826,7 @@ struct vkd3d_shader_indexable_temp

struct vkd3d_shader_register_index
 {
-    const struct vkd3d_shader_src_param *rel_addr;
+    struct vkd3d_shader_src_param *rel_addr;
     unsigned int offset;
     /* address is known to fall within the object (for optimisation) */
     bool is_in_bounds;

[Giovanni Mascellani (＠giomasce)]

On Thu Jan 18 15:03:01 2024 +0000, Giovanni Mascellani wrote:
> I added a few other changes that should help reducing conflict between
> !564 and !514.

To hopefully improve latency I moved those changes to !573 and !574.

[PATCH v6 0/3] MR568: vkd3d-shader: Miscellaneous changes in view of the CFG structurizer. - approved

[Henri Verbeet (＠hverbeet)]

This merge request was approved by Henri Verbeet.