On Thu Jun 1 16:21:55 2023 +0000, Zebediah Figura wrote:
Rémi Bernon removed review request for @zfigura May 31, 2023, 10:57 AM
Please don't do that. In this case it's fine since I've reviewed the patch and was going to sign off on it anyway.
Well I don't know that, it's been mostly a week without any activity and it's not the first time winegstreamer MR have been left unnoticed. I have been upstreaming winegstreamer patches for a big part of last year and the slow iteration have been making it very difficult. We have patches piling up in Proton once again, and diverging implementations already. I would very much like to avoid getting in the same situation as we've been.
I don't think these changes present any risk, they have been thoroughly tested, by Paul and I, but also with a lot of Wine tests, and the changes have been in Proton for a long while already. I also maintain wg_transform and their client, so, although I'm happy to take constructive comments, I'm ultimately going to be responsible for the changes.