Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
On Sun Feb 16 17:01:28 2025 +0000, eric pouech wrote:
globally it looks better a couple of stylistic remarks, but you need to go further for not using errorlevel inside the function and its helper perhaps, it's worthwhile to split the patch in two:
- first one to no longer use error level internally, adapt
list_directory prototype... (in the details, it's fine to use return errorlevel = ERROR_* while parsing the arguments in case of error, but when this is done all the rest of the code should use only the return_code (and set errorlevel when exiting WCMD_dir))
- the second one to plug in the ctrl-c handling and breaking from the
various loops
I only ever intended to do the second part. I've been doing the rest per your suggestions out of goodwill.
I'll continue to fix up the first part per your suggestions but I don't have the energy to split this into separate patches. I'll address the remaining issues that you have raised today but that's going to be it from me I'm afraid on this.
-
Joe Souza (＠JoeS209)