[PATCH 0/1] MR3977: secur32: Only return success from initialize_package() when initialization fully succeeds.

[Hans Leidekker (＠hans)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55522

[PATCH 1/1] secur32: Only return success from initialize_package() when initialization fully succeeds.

[Hans Leidekker]

From: Hans Leidekker

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55522
---
 dlls/secur32/lsa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/secur32/lsa.c b/dlls/secur32/lsa.c
index 3b124c4da1f..7af9c285d86 100644
--- a/dlls/secur32/lsa.c
+++ b/dlls/secur32/lsa.c
@@ -907,10 +907,12 @@ static BOOL initialize_package(struct lsa_package *package,
             {
                 status = pSpUserModeInitialize(SECPKG_INTERFACE_VERSION, &package->user_api_version, &package->user_api, &package->user_table_count);
                 if (status == STATUS_SUCCESS)
+                {
                     package->user_api->InstanceInit(SECPKG_INTERFACE_VERSION, &lsa_dll_dispatch, NULL);
+                    return TRUE;
+                }
             }
         }
-        return TRUE;
     }

return FALSE;

[PATCH 1/1] secur32: Only return success from initialize_package() when initialization fully succeeds.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=138037

Your paranoid android.

=== debian11b (64 bit WoW report) ===

msvcr120:
msvcr120.c:1596: Test failed: Chore's task collection was not reset after execution