[PATCH v3 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.

[xantares (＠xantares)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950

--
  v3: msvcrt: Fix errno set on dup from read-only file.

https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

[PATCH v3 1/1] msvcrt: Fix errno set on dup from read-only file.

[Michel Zou]

From: Michel Zou

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950
---
 dlls/msvcrt/file.c       | 1 +
 dlls/msvcrt/tests/file.c | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c
index 4a8c3510bd7..e72784eef41 100644
--- a/dlls/msvcrt/file.c
+++ b/dlls/msvcrt/file.c
@@ -1244,6 +1244,7 @@ int CDECL _dup2(int od, int nd)

if (info_nd == &MSVCRT___badioinfo)
   {
+      *_errno() = EBADF;
       ret = -1;
   }
   else if (info_od->wxflag & WX_OPEN)
diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c
index de21d11d0b9..b03a8faaf89 100644
--- a/dlls/msvcrt/tests/file.c
+++ b/dlls/msvcrt/tests/file.c
@@ -267,6 +267,12 @@ static void test_readmode( BOOL ascii_mode )

close (fd);

+    fd = open ("fdopen.tst", O_RDONLY, _S_IREAD |_S_IWRITE);
+    errno = 0xdeadbeef;
+    ok(dup2(fd, -1) == -1, "dup2 succeeded on read-only file\n");
+    ok(errno == EBADF, "errno = %d\n", errno);
+    close (fd);
+
     if (ascii_mode) {
         /* Open file in ascii mode */
         fd = open ("fdopen.tst", O_RDONLY);

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/file.c:
>  close (fd);
>
> - fd = open ("fdopen.tst", O_RDONLY, _S_IREAD |_S_IWRITE);
> - errno = 0xdeadbeef;
> - ok(dup2(fd, -1) == -1, "dup2 succeeded on read-only file\n");

dup2 is failing because second argument is -1, not because it's a read-only file.
```suggestion:-0+0
    ok(dup2(fd, -1) == -1, "dup2(fd, -1) succeeded\n");
```