On Fri Sep 8 06:50:30 2023 +0000, Henri Verbeet wrote:
At first sight this looks fine, thanks. Unfortunately I probably won't be able to properly review this this week, but I should be able to get to it early next week. Note that this currently fails the CI though. Probably because it's intended to be applied on top of !325, so hopefully that will get resolved once those patches actually get committed.
It still fails CI after !325 was merged (and even before - as it was based on top of !325, those commits were part of this branch so testing would just have iterated over those too) - not quite sure what is wrong here...