[PATCH v3 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse

[Lucas Chollet (＠LucasChollet)]

This is needed by Moku (software for scientific instrument):
https://www.liquidinstruments.com/products/desktop-apps/

Related to:
Wine-Bug: https://forum.winehq.org/viewtopic.php?p=143283

---

First contribution here, I will happily make change if needed!

--
  v3: dnsapi: Add a stub for DnsServiceBrowse

https://gitlab.winehq.org/wine/wine/-/merge_requests/5831

[PATCH v3 1/1] dnsapi: Add a stub for DnsServiceBrowse

[Lucas Chollet]

From: Lucas Chollet

This is needed by Moku (software for scientific instrument):
https://www.liquidinstruments.com/products/desktop-apps/

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56828
---
 dlls/dnsapi/dnsapi.spec |  1 +
 dlls/dnsapi/main.c      | 10 ++++++++++
 include/windns.h        | 21 +++++++++++++++++++++
 3 files changed, 32 insertions(+)

diff --git a/dlls/dnsapi/dnsapi.spec b/dlls/dnsapi/dnsapi.spec
index 0d50c56ec68..a8ffa40a0ae 100644
--- a/dlls/dnsapi/dnsapi.spec
+++ b/dlls/dnsapi/dnsapi.spec
@@ -103,6 +103,7 @@
 @ stub DnsReplaceRecordSet_UTF8
 @ stdcall DnsReplaceRecordSetW(ptr long ptr ptr ptr)
 @ stub DnsReplaceRecordSet_W
+@ stdcall DnsServiceBrowse(ptr ptr)
 @ stub DnsServiceNotificationDeregister_A
 @ stub DnsServiceNotificationDeregister_UTF8
 @ stub DnsServiceNotificationDeregister_W
diff --git a/dlls/dnsapi/main.c b/dlls/dnsapi/main.c
index 6324d46e173..9b057a09a05 100644
--- a/dlls/dnsapi/main.c
+++ b/dlls/dnsapi/main.c
@@ -233,3 +233,13 @@ DNS_STATUS WINAPI DnsReplaceRecordSetW( DNS_RECORDW *set, DWORD options, HANDLE
     FIXME( "(%p, %#lx, %p, %p, %p) stub\n", set, options, context, servers, reserved );
     return ERROR_SUCCESS;
 }
+
+/******************************************************************************
+ * DnsServiceBrowse                        [DNSAPI.@]
+ *
+ */
+DNS_STATUS WINAPI DnsServiceBrowse( PDNS_SERVICE_BROWSE_REQUEST request, PDNS_SERVICE_CANCEL cancel)
+{
+    FIXME( "(%p, %p) stub\n", request, cancel );
+    return ERROR_SUCCESS;
+}
diff --git a/include/windns.h b/include/windns.h
index b0b14df1b4f..11c0be9dfd2 100644
--- a/include/windns.h
+++ b/include/windns.h
@@ -760,6 +760,26 @@ typedef struct _DNS_CACHE_ENTRY
     ULONG Flags;
 } DNS_CACHE_ENTRY, *PDNS_CACHE_ENTRY;

+typedef void WINAPI DNS_SERVICE_BROWSE_CALLBACK(DWORD, void *, PDNS_RECORD);
+typedef DNS_SERVICE_BROWSE_CALLBACK *PDNS_SERVICE_BROWSE_CALLBACK; 
+
+typedef struct _DNS_SERVICE_BROWSE_REQUEST
+{
+  ULONG Version;
+  ULONG InterfaceIndex;
+  const WCHAR *QueryName;
+  union {
+    PDNS_SERVICE_BROWSE_CALLBACK pBrowseCallback;
+    DNS_QUERY_COMPLETION_ROUTINE *pBrowseCallbackV2;
+  };
+  void *pQueryContext;
+} DNS_SERVICE_BROWSE_REQUEST, *PDNS_SERVICE_BROWSE_REQUEST;
+
+typedef struct _DNS_SERVICE_CANCEL
+{
+  void *reserved;
+} DNS_SERVICE_CANCEL, *PDNS_SERVICE_CANCEL;
+
 DNS_STATUS WINAPI DnsAcquireContextHandle_A(DWORD,PVOID,PHANDLE);
 DNS_STATUS WINAPI DnsAcquireContextHandle_W(DWORD,PVOID,PHANDLE);
 #define DnsAcquireContextHandle WINELIB_NAME_AW(DnsAcquireContextHandle_)
@@ -790,6 +810,7 @@ void WINAPI DnsReleaseContextHandle(HANDLE);
 DNS_STATUS WINAPI DnsReplaceRecordSetA(PDNS_RECORDA,DWORD,HANDLE,PVOID,PVOID);
 DNS_STATUS WINAPI DnsReplaceRecordSetW(PDNS_RECORDW,DWORD,HANDLE,PVOID,PVOID);
 DNS_STATUS WINAPI DnsReplaceRecordSetUTF8(PDNS_RECORDA,DWORD,HANDLE,PVOID,PVOID);
+DNS_STATUS WINAPI DnsServiceBrowse(PDNS_SERVICE_BROWSE_REQUEST, PDNS_SERVICE_CANCEL);
 #define DnsReplaceRecordSet WINELIB_NAME_AW(DnsReplaceRecordSet)
 DNS_STATUS WINAPI DnsValidateName_A(PCSTR,DNS_NAME_FORMAT);
 DNS_STATUS WINAPI DnsValidateName_W(PCWSTR, DNS_NAME_FORMAT);

[Lucas Chollet (＠LucasChollet)]

Sure, the bug report is created! I'm not familiar with Wine's workflow, so thanks for the pointers.

[PATCH v3 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.