Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c:
> - IO_STATUS_BLOCK io;
> - UINT data_size = sizeof(FILE_DIRECTORY_INFORMATION) + (MAX_PATH * sizeof(wchar_t));
> - BYTE data[8192];
> - FILE_DIRECTORY_INFORMATION *dir_info;
> - WCHAR *name;
> - ULONG name_len;
> - ULONG mask_len = mask.Length / sizeof(WCHAR);
> -
> - /* Perform the query */
> - status = pNtQueryDirectoryFile( handle, NULL, NULL, NULL, &io, data, data_size,
> -
>                                FileDirectoryInformation, TRUE, &mask, restart_scan );
> - if (expect_success)
> - {
> -
>    if (validate_only && status != STATUS_SUCCESS) return FALSE;
> -
> -
>    ok( status == STATUS_SUCCESS, "could not find file mask: '%s', restart: %d, error %ld\n",

tracing GetLastError() is pointless here (you're testing ntdll APIs, while GetLastError() reflects kernel32/kernelbase API results)