Re: [PATCH v13 0/1] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/sane.ds/ui.c:
> - if (changed)
> - {
> -
>    save_cfg_data(NULL, path, SINGLE, opt.optno);
> -
>    InitializeDialog(hwnd);
> - }
> free( value );
>
> }
>
> +LRESULT CALLBACK SaveWindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
> +{
> - switch (uMsg)
> - {
> -
>    case WM_CREATE:
> -
>    {
> -
>        RECT rcClient;
> -
>        HWND tag, edit, btnSave, btnLoad;

This seems like unnecessarily complicated UI to me. Why not just have Save and Load buttons in the main window that bring up standard Open/Save dialogs? (And maybe a "Save Defaults" that writes it to the default location. That could be added first, with the extra dialogs added in a later commit.)