Re: [PATCH v2 0/4] MR5161: d3drm: Implement Update and related functions

[Stefan Dösinger (＠stefan)]

Stefan Dösinger (@stefan) commented about dlls/d3drm/tests/d3drm.c:
> - DWORD clip_list_size;
> - RGNDATA *clip_list;
> - HWND window;
> - HRESULT hr;
> -
> - window = create_window();
> -
> - /* Set up device */
> - hr = DirectDrawCreateClipper(0, &clipper, NULL);
> - ok(hr == DD_OK, "Cannot get IDirectDrawClipper interface, hr %#lx.\n", hr);
> - hr = IDirectDrawClipper_SetHWnd(clipper, 0, window);
> - ok(hr == DD_OK, "Cannot set HWnd to Clipper, hr %#lx.\n", hr);
> - hr = Direct3DRMCreate(&d3drm1);
> - ok(SUCCEEDED(hr), "Cannot create IDirect3DRM instance, hr %#lx.\n", hr);
> - hr = IDirect3DRM_CreateDeviceFromClipper(d3drm1, clipper, &driver, dev_width, dev_height, &device1);
> - ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice interface, hr %#lx.\n", hr);

This is more a curiosity rather than something that needs to be addressed in this patch: Dies CreateDeviceFromClipper fail if the clipper has no window (but instead a cliplist or simply nothing)?

I would expect it to fail, but otoh SetCooperativeLevel on a NULL HWND works in DDSCL_NORMAL I think.