Followup to: 3e67471d02
Looks like this sould be a >= as it affects just d3dx10_40, at least with it the test succeeds on testbot.
[Test pattern page](https://test.winehq.org/data/patterns.html#d3dx10_40:d3dx10)
[Test pattern page, Aug 21 Summary for build e155f7c04b7c](https://test.winehq.org/data/e155f7c04b7c529af9e0f64ee3db8ef3f67558b0/#d3dx1...)
[Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=159474)
From: Bernhard Übelacker bernhardu@mailbox.org
Followup to: 3e67471d02 --- dlls/d3dx10_43/tests/d3dx10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c index ded2940ba46..cd9f6487fc6 100644 --- a/dlls/d3dx10_43/tests/d3dx10.c +++ b/dlls/d3dx10_43/tests/d3dx10.c @@ -4382,7 +4382,7 @@ static void test_create_effect_from_memory(void) /* Empty buffers are always included before version 40. */ hr = effect->lpVtbl->GetDesc(effect, &desc); ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); -#if D3DX10_SDK_VERSION > 40 +#if D3DX10_SDK_VERSION >= 40 ok(desc.ConstantBuffers == 1, "Unexpected buffer count.\n"); #else todo_wine
Looks good to me.
This merge request was closed by Bernhard Übelacker.
Got committed as part of 1acc0f2b4e3.
On Tue Aug 26 09:02:48 2025 +0000, Bernhard Übelacker wrote:
Got committed as part of 1acc0f2b4e3.
Oh, sorry about that. That wasn't intentional, I just pushed it together with my branch.
On Tue Aug 26 09:02:48 2025 +0000, Nikolay Sivov wrote:
Oh, sorry about that. That wasn't intentional, I just pushed it together with my branch.
No problem, just wondered why the test started to succeed.