[PATCH v3 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button.

[Fabian Maurer (＠DarkShadow44)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55841

--
  v3: printdlg: Allow button id psh1 for "Properties" button.

https://gitlab.winehq.org/wine/wine/-/merge_requests/6119

[PATCH v3 1/1] printdlg: Allow button id psh1 for "Properties" button.

[Fabian Maurer]

From: Fabian Maurer

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55841
---
 dlls/comdlg32/printdlg.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c
index aed486a9b09..b5c67c3abad 100644
--- a/dlls/comdlg32/printdlg.c
+++ b/dlls/comdlg32/printdlg.c
@@ -1796,6 +1796,7 @@ static LRESULT PRINTDLG_WMCommandA(HWND hDlg, WPARAM wParam,
    }
    break;

+     case psh1:                       /* Setup button */
      case psh2:                       /* Properties button */
        {
          HANDLE hPrinter;
@@ -1952,6 +1953,7 @@ static LRESULT PRINTDLG_WMCommandW(HWND hDlg, WPARAM wParam,
         }
         break;

+     case psh1:                       /* Setup button */
      case psh2:                       /* Properties button */
        {
          HANDLE hPrinter;

[PATCH v3 1/1] printdlg: Allow button id psh1 for "Properties" button.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147664

Your paranoid android.

=== debian11b (64 bit WoW report) ===

dinput:
joystick8.c:5762: Test failed: input 1: WaitForSingleObject returned 0x102
joystick8.c:5763: Test failed: input 1: got 0 WM_INPUT messages
joystick8.c:5766: Test failed: input 1: got dwType 0
joystick8.c:5767: Test failed: input 1: got header.dwSize 0
joystick8.c:5769: Test failed: input 1: got hDevice 0000000000000000
joystick8.c:5771: Test failed: input 1: got dwSizeHid 0
joystick8.c:5772: Test failed: input 1: got dwCount 0

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000005900F2, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Fabian Maurer (＠DarkShadow44)]

On Sat Aug 10 15:08:42 2024 +0000, Huw Davies wrote:
> We should presumably also update `PRINTDLG_WMCommandW()`.

Sure, updated.

[PATCH v3 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.