Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)

[Ralf Habacker (＠rhabacker)]

Ralf Habacker (@rhabacker) commented about server/sock.c:
> -
>            if (!(unix_path = mem_alloc( unix_path_len + 1 )))
> -
>                return;
> -
> -
>            memcpy( unix_path, (char *)(params + 1) + params->addr_len, unix_path_len );
> -
>            unix_path[unix_path_len] = '\0';
> -
> -
>            base_name = strrchr(unix_path, '/');
> -
>            if (base_name)
> -
>            {
> -
>                if (base_name != unix_path)
> -
>                    (++base_name)[-1] = '\0';
> -
>            }
> -
>            else
> -
>                base_name = unix_path;
> -
> -
>            if (chdir( unix_path ) == -1)

At https://gitlab.winehq.org/wine/wine/-/merge_requests/7519 it is pointed out that changing the working directory may not be a good idea, so it should be checked whether this can be avoided.