Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Sven Baars (＠sbaars)]

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c:
> - full_pidl = ILCombine(This->pidl, This->apidl[0]);
> - if (!full_pidl)
> - {
> -
>    ERR("Out of Memory\n");
> -
>    return;
> - }
> -
> - hr = IShellLinkW_SetIDList(shelllink, full_pidl);
> - ILFree(full_pidl);
> - if (FAILED(hr))
> - {
> -
>    ERR("SetIDList failed\n");
> -
>    return;
> - }
> - _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH);
> - length = wcslen(filename) + wcslen(shortcutW);

This looks like a duplicate check. There is another one in the loop below.