Current code handles omitted deleteCount but assumes it to be zero in that case. Instead an omitted deleteCount means delete everything from `start`.
This prevents Adobe sign-in page from loading.
-- v4: jscript: fix Array.prototype.splice with omitted deleteCount in html mode
From: Yuxuan Shui yshui@codeweavers.com
--- dlls/jscript/array.c | 2 ++ dlls/jscript/tests/api.js | 4 ++-- dlls/mshtml/tests/documentmode.js | 7 +++++++ 3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 4e1af864a8e..d4ec197b13a 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -870,6 +870,8 @@ static HRESULT Array_splice(script_ctx_t *ctx, jsval_t vthis, WORD flags, unsign }
add_args = argc-2; + } else if (argc && ctx->html_mode) { + delete_cnt = length-start; }
if(r) { diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 0fc683c20cb..aea412347b9 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -1310,8 +1310,8 @@ ok(arr.toString() == "1,2,3,4,5", "arr.splice(2,-1) is " + arr.toString());
arr = [1,2,3,4,5]; tmp = arr.splice(2); -ok(tmp.toString() == "", "arr.splice(2,-1) returned " + tmp.toString()); -ok(arr.toString() == "1,2,3,4,5", "arr.splice(2,-1) is " + arr.toString()); +ok(tmp.toString() == "", "arr.splice(2) returned " + tmp.toString()); +ok(arr.toString() == "1,2,3,4,5", "arr.splice(2) is " + arr.toString());
arr = [1,2,3,4,5]; tmp = arr.splice(); diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js index 9f46de12466..63dd36c8ea3 100644 --- a/dlls/mshtml/tests/documentmode.js +++ b/dlls/mshtml/tests/documentmode.js @@ -813,6 +813,13 @@ sync_test("eval", function() { ok(context.barfoo === 4321, "context.barfoo = " + context.barfoo); });
+sync_test("array_splice", function() { + var arr = [1,2,3,4,5] + tmp = arr.splice(2); + ok(arr.toString() === "1,2", "arr = " + arr + " when documentMode is " + document.documentMode); + ok(tmp.toString() === "3,4,5", "tmp = " + tmp + " when documentMode is " + document.documentMode); +}); + sync_test("for..in", function() { var v = document.documentMode, found = 0, r;
Hi,
It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated.
The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details:
The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=136206
Your paranoid android.
=== w7u_2qxl (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w7u_adm (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w7u_el (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w8 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w8adm (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w864 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064v1507 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064v1809 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064_tsign (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w11pro64 (32 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w7pro64 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w864 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064v1507 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064v1809 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064_2qxl (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064_adm (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w1064_tsign (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64_en_AE_u8 (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64_ar (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64_ja (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w10pro64_zh_CN (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
=== w11pro64_amd (64 bit report) ===
mshtml: script.c:1126: Test failed: L"index.html?0:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?0:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: arr = 1,2,3,4,5 when documentMode is 5" script.c:1126: Test failed: L"index.html?5:array_splice: tmp = when documentMode is 5" script.c:1126: Test failed: L"index.html?7:array_splice: arr = 1,2,3,4,5 when documentMode is 7" script.c:1126: Test failed: L"index.html?7:array_splice: tmp = when documentMode is 7" script.c:1126: Test failed: L"index.html?8:array_splice: arr = 1,2,3,4,5 when documentMode is 8" script.c:1126: Test failed: L"index.html?8:array_splice: tmp = when documentMode is 8"
On Tue Aug 15 12:10:09 2023 +0000, Gabriel Ivăncescu wrote:
Are you sure this is html mode specific? To confirm, you should move the test to `documentmode.js` and see what happens in every mode, `es5.js` is for ES5+ (IE9+, but we test it in IE11 mode only). If it turns out to be ES5 for example, you can use ctx->version >= SCRIPTLANGUAGEVERSION_ES5 instead. Otherwise you can keep html mode of course, if it works in all modes the same.
Thanks, I should've been more thorough.
On Tue Aug 15 13:46:06 2023 +0000, Yuxuan Shui wrote:
Thanks, I should've been more thorough.
~~It turns out it does behave the same on every documentMode.~~
On Tue Aug 15 13:49:26 2023 +0000, Yuxuan Shui wrote:
~~It turns out it does behave the same on every documentMode.~~
Sorry, turns out I need to rebuild after changing the script.
-
Marvin -
Yuxuan Shui -
Yuxuan Shui (＠yshui)